code review 13112043: codereview: update use of promptchoice for Mercurial 2.7

codereview: update use of promptchoice for Mercurial 2.7

Fixes issue 6186.

[ality, 2013-08-19 22:43:13]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-08-19 22:44:50]

Is that a string-wise >= ?

Oh, whatever, this file has to change for every hg point release anyway.



On Mon, Aug 19, 2013 at 3:43 PM, <ality@pbrane.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> codereview: update use of promptchoice for Mercurial 2.7
>
> Fixes issue 6186.
>
> Please review this at
https://codereview.appspot.**com/13112043/<https://codereview.appspot.com/131...
>
> Affected files:
>   M lib/codereview/codereview.py
>
>
> Index: lib/codereview/codereview.py
> ==============================**==============================**=======
> --- a/lib/codereview/codereview.py
> +++ b/lib/codereview/codereview.py
> @@ -712,7 +712,10 @@
>  '''
>
>  def promptyesno(ui, msg):
> -       return ui.promptchoice(msg, ["&yes", "&no"], 0) == 0
> +       if hgversion >= "2.7":
> +               return ui.promptchoice(msg + " $$ &yes $$ &no", 0) == 0
> +       else:
> +               return ui.promptchoice(msg, ["&yes", "&no"], 0) == 0
>
>  def promptremove(ui, repo, f):
>         if promptyesno(ui, "hg remove %s (y/n)?" % (f,)):
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[ality, 2013-08-19 22:56:52]

Brad Fitzpatrick <bradfitz@golang.org> once said:
> Is that a string-wise >= ?

Yes. I just followed the convention in this file.
All other comparisons to hgversion are like that.

  Anthony

[bradfitz, 2013-08-21 16:14:33]

Just curious. I don't understand this code.

LGTM though if you've tested a bunch of hg versions and it didn't regress.
 On Aug 19, 2013 3:56 PM, "Anthony Martin" <ality@pbrane.org> wrote:

> Brad Fitzpatrick <bradfitz@golang.org> once said:
> > Is that a string-wise >= ?
>
> Yes. I just followed the convention in this file.
> All other comparisons to hgversion are like that.
>
>   Anthony
>

[remyoudompheng, 2013-09-05 19:37:20]

ping?

[rsc, 2013-09-05 19:38:05]

LGTM

[rsc, 2013-09-06 19:48:25]

*** Submitted as https://code.google.com/p/go/source/detail?r=7b317abe8dd5 ***

codereview: update use of promptchoice for Mercurial 2.7

Fixes issue 6186.

R=golang-dev, bradfitz, remyoudompheng, rsc
CC=golang-dev
https://codereview.appspot.com/13112043

Committer: Russ Cox <rsc@golang.org>