Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(770)

Issue 13435043: code review 13435043: compress/gzip: add Writer.Reset (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 2 months ago by bradfitz
Modified:
4 years, 2 months ago
Reviewers:
r, iant
CC:
golang-dev, iant
Visibility:
Public.

Description

compress/gzip: add Writer.Reset compress/flate is https://codereview.appspot.com/12953048 compress/zlib is https://codereview.appspot.com/13171046 Update Issue 6138

Patch Set 1 #

Patch Set 2 : diff -r bf9de8d2e308 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r bf9de8d2e308 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r bf9de8d2e308 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -17 lines) Patch
M src/pkg/compress/gzip/gzip.go View 1 2 3 6 chunks +49 lines, -17 lines 0 comments Download
M src/pkg/compress/gzip/gzip_test.go View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 4
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
4 years, 2 months ago (2013-08-30 17:08:48 UTC) #1
iant
LGTM https://codereview.appspot.com/13435043/diff/5001/src/pkg/compress/gzip/gzip.go File src/pkg/compress/gzip/gzip.go (right): https://codereview.appspot.com/13435043/diff/5001/src/pkg/compress/gzip/gzip.go#newcode95 src/pkg/compress/gzip/gzip.go:95: // writing to w instead. Would it be ...
4 years, 2 months ago (2013-08-30 18:15:24 UTC) #2
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=0365e0923a8f *** compress/gzip: add Writer.Reset compress/flate is https://codereview.appspot.com/12953048 compress/zlib is https://codereview.appspot.com/13171046 Update ...
4 years, 2 months ago (2013-08-30 18:41:21 UTC) #3
r
4 years, 2 months ago (2013-08-30 21:56:00 UTC) #4
go1.2.txt please
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4