Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 13171046: code review 13171046: compress/zlib: add Reset method to Writer. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 2 months ago by remyoudompheng
Modified:
4 years, 2 months ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

compress/zlib: add Reset method to Writer.

Patch Set 1 #

Patch Set 2 : diff -r bc785da349e2 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r bc785da349e2 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f2e954f463e0 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 5 : diff -r f31ef66588fc https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r f31ef66588fc https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -4 lines) Patch
M src/pkg/compress/zlib/writer.go View 1 2 3 4 5 2 chunks +25 lines, -4 lines 0 comments Download
M src/pkg/compress/zlib/writer_test.go View 1 2 3 2 chunks +65 lines, -0 lines 0 comments Download

Messages

Total messages: 6
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
4 years, 2 months ago (2013-08-24 11:03:47 UTC) #1
bradfitz
This also needs to preserve the dictionary, right? On Sat, Aug 24, 2013 at 4:03 ...
4 years, 2 months ago (2013-08-28 18:28:38 UTC) #2
remyoudompheng
On 2013/08/28 18:28:38, bradfitz wrote: > This also needs to preserve the dictionary, right? Yes, ...
4 years, 2 months ago (2013-08-29 10:31:01 UTC) #3
remyoudompheng
Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
4 years, 2 months ago (2013-08-29 10:31:13 UTC) #4
bradfitz
LGTM https://codereview.appspot.com/13171046/diff/12001/src/pkg/compress/zlib/writer.go File src/pkg/compress/zlib/writer.go (right): https://codereview.appspot.com/13171046/diff/12001/src/pkg/compress/zlib/writer.go#newcode73 src/pkg/compress/zlib/writer.go:73: // Reset clears a Writer state so that ...
4 years, 2 months ago (2013-08-29 18:52:48 UTC) #5
remyoudompheng
4 years, 2 months ago (2013-09-05 19:50:56 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=4053c76d9817 ***

compress/zlib: add Reset method to Writer.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13171046

https://codereview.appspot.com/13171046/diff/12001/src/pkg/compress/zlib/writ...
File src/pkg/compress/zlib/writer.go (right):

https://codereview.appspot.com/13171046/diff/12001/src/pkg/compress/zlib/writ...
src/pkg/compress/zlib/writer.go:73: // Reset clears a Writer state so that it is
equivalent to the result of
On 2013/08/29 18:52:48, bradfitz wrote:
> Maybe:
> 
> // Reset clears the state of the Writer z such that it is equivalent to its
> // initial state from NewWriterLevel or NewWriterLevelDict,
> // but instead writing to w.
> 

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4