Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(769)

Issue 12953048: code review 12953048: compress/flate: implement Reset method on Writer. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 2 months ago by remyoudompheng
Modified:
4 years, 2 months ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

compress/flate: implement Reset method on Writer. Fixes issue 6138.

Patch Set 1 #

Patch Set 2 : diff -r bc785da349e2 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r bc785da349e2 https://go.googlecode.com/hg/ #

Total comments: 3

Patch Set 4 : diff -r f2e954f463e0 https://go.googlecode.com/hg/ #

Total comments: 6

Patch Set 5 : diff -r 84a92114983d https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r ea828ad3abe7 https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r ea828ad3abe7 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -2 lines) Patch
M src/pkg/compress/flate/deflate.go View 1 2 3 4 5 chunks +65 lines, -2 lines 0 comments Download
M src/pkg/compress/flate/deflate_test.go View 1 2 3 2 chunks +64 lines, -0 lines 0 comments Download
M src/pkg/compress/flate/huffman_bit_writer.go View 1 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 13
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
4 years, 2 months ago (2013-08-24 07:48:36 UTC) #1
remyoudompheng
TestWriterReset may be a bit slow because of the use of DeepEqual, but it can ...
4 years, 2 months ago (2013-08-24 07:50:06 UTC) #2
bradfitz
https://codereview.appspot.com/12953048/diff/6001/src/pkg/compress/flate/deflate.go File src/pkg/compress/flate/deflate.go (right): https://codereview.appspot.com/12953048/diff/6001/src/pkg/compress/flate/deflate.go#newcode554 src/pkg/compress/flate/deflate.go:554: func (writer *Writer) Reset(w io.Writer) error { receiver should ...
4 years, 2 months ago (2013-08-24 14:38:01 UTC) #3
remyoudompheng
https://codereview.appspot.com/12953048/diff/6001/src/pkg/compress/flate/deflate.go File src/pkg/compress/flate/deflate.go (right): https://codereview.appspot.com/12953048/diff/6001/src/pkg/compress/flate/deflate.go#newcode554 src/pkg/compress/flate/deflate.go:554: func (writer *Writer) Reset(w io.Writer) error { On 2013/08/24 ...
4 years, 2 months ago (2013-08-24 15:55:22 UTC) #4
bradfitz
On Sat, Aug 24, 2013 at 10:55 AM, <remyoudompheng@gmail.com> wrote: > > https://codereview.appspot.**com/12953048/diff/6001/src/** > pkg/compress/flate/deflate.go<https://codereview.appspot.com/12953048/diff/6001/src/pkg/compress/flate/deflate.go> ...
4 years, 2 months ago (2013-08-24 15:58:51 UTC) #5
remyoudompheng
On 2013/08/24 15:58:51, bradfitz wrote: > If we make it Reset(dict []byte) where dict is ...
4 years, 2 months ago (2013-08-24 16:03:47 UTC) #6
bradfitz
Let's just go with as simple and least surprising of an API for now. We ...
4 years, 2 months ago (2013-08-24 16:07:55 UTC) #7
remyoudompheng
https://codereview.appspot.com/12953048/diff/6001/src/pkg/compress/flate/deflate.go File src/pkg/compress/flate/deflate.go (right): https://codereview.appspot.com/12953048/diff/6001/src/pkg/compress/flate/deflate.go#newcode554 src/pkg/compress/flate/deflate.go:554: func (writer *Writer) Reset(w io.Writer) error { On 2013/08/24 ...
4 years, 2 months ago (2013-08-29 10:10:23 UTC) #8
remyoudompheng
Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
4 years, 2 months ago (2013-08-29 10:10:41 UTC) #9
bradfitz
LGTM https://codereview.appspot.com/12953048/diff/16001/src/pkg/compress/flate/deflate.go File src/pkg/compress/flate/deflate.go (right): https://codereview.appspot.com/12953048/diff/16001/src/pkg/compress/flate/deflate.go#newcode435 src/pkg/compress/flate/deflate.go:435: for s := d.hashHead; len(s) > 0; s ...
4 years, 2 months ago (2013-08-29 18:45:30 UTC) #10
remyoudompheng
https://codereview.appspot.com/12953048/diff/16001/src/pkg/compress/flate/deflate.go File src/pkg/compress/flate/deflate.go (right): https://codereview.appspot.com/12953048/diff/16001/src/pkg/compress/flate/deflate.go#newcode435 src/pkg/compress/flate/deflate.go:435: for s := d.hashHead; len(s) > 0; s = ...
4 years, 2 months ago (2013-08-29 19:01:14 UTC) #11
bradfitz
LGTM
4 years, 2 months ago (2013-08-29 19:03:48 UTC) #12
remyoudompheng
4 years, 2 months ago (2013-08-29 19:09:35 UTC) #13
*** Submitted as https://code.google.com/p/go/source/detail?r=fe4bfff38132 ***

compress/flate: implement Reset method on Writer.

Fixes issue 6138.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12953048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4