Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1455)

Issue 133830043: code review 133830043: cmd/gc: re-enable IfacePointerOnly (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 1 month ago by rsc
Modified:
3 years, 1 month ago
Reviewers:
dfc, bradfitz
CC:
golang-codereviews, bradfitz, dfc, r
Visibility:
Public.

Description

cmd/gc: re-enable IfacePointerOnly CL 130240043 did this but broke ARM, because it made newErrorCString start allocating, so we rolled it back in CL 133810043. CL 133820043 removed that allocation. Try again. Fixes issue 8405.

Patch Set 1 #

Patch Set 2 : diff -r e3775b98a6638ee3c69763f615a3eea4c61e6485 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 213bbe0c1f7726de79543e72af8d5ce27461012e https://code.google.com/p/go/ #

Patch Set 4 : diff -r 7db430d2938c84929631ccff90f7b81d29956fbb https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/gc/subr.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-codereviews@googlegroups.com (cc: dfc, r), I'd like you to review this change to https://code.google.com/p/go/
3 years, 1 month ago (2014-08-25 00:27:48 UTC) #1
bradfitz
LGTM On Aug 24, 2014 5:27 PM, <rsc@golang.org> wrote: > Reviewers: golang-codereviews, > > Message: ...
3 years, 1 month ago (2014-08-25 00:29:30 UTC) #2
dfc
LGTM. On Mon, Aug 25, 2014 at 10:27 AM, <rsc@golang.org> wrote: > Reviewers: golang-codereviews, > ...
3 years, 1 month ago (2014-08-25 00:29:34 UTC) #3
rsc
3 years, 1 month ago (2014-08-25 00:31:40 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=cf7fe9f1fd36 ***

cmd/gc: re-enable IfacePointerOnly

CL 130240043 did this but broke ARM, because
it made newErrorCString start allocating, so we rolled
it back in CL 133810043.

CL 133820043 removed that allocation.

Try again.

Fixes issue 8405.

LGTM=bradfitz, dave
R=golang-codereviews, bradfitz
CC=dave, golang-codereviews, r
https://codereview.appspot.com/133830043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted