code review 133830043: cmd/gc: re-enable IfacePointerOnly

cmd/gc: re-enable IfacePointerOnly

CL 130240043 did this but broke ARM, because
it made newErrorCString start allocating, so we rolled
it back in CL 133810043.

CL 133820043 removed that allocation.

Try again.

Fixes issue 8405.

[rsc, 2014-08-25 00:27:48]

Hello golang-codereviews@googlegroups.com (cc: dfc, r),

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2014-08-25 00:29:30]

LGTM
On Aug 24, 2014 5:27 PM, <rsc@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com (cc: dfc, r),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> cmd/gc: re-enable IfacePointerOnly
>
> CL 130240043 did this but broke ARM, because
> it made newErrorCString start allocating, so we rolled
> it back in CL 133810043.
>
> CL 133820043 removed that allocation.
>
> Try again.
>
> Fixes issue 8405.
>
> Please review this at https://codereview.appspot.com/133830043/
>
> Affected files (+1, -1 lines):
>   M src/cmd/gc/subr.c
>
>
> Index: src/cmd/gc/subr.c
> ===================================================================
> --- a/src/cmd/gc/subr.c
> +++ b/src/cmd/gc/subr.c
> @@ -3808,7 +3808,7 @@
>         // where the data word can hold a pointer or any
>         // non-pointer value no bigger than a pointer.
>         enum {
> -               IfacePointerOnly = 0,
> +               IfacePointerOnly = 1,
>         };
>
>         if(IfacePointerOnly) {
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[dfc, 2014-08-25 00:29:34]

LGTM.

On Mon, Aug 25, 2014 at 10:27 AM,  <rsc@golang.org> wrote:
> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com (cc: dfc, r),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> cmd/gc: re-enable IfacePointerOnly
>
> CL 130240043 did this but broke ARM, because
> it made newErrorCString start allocating, so we rolled
> it back in CL 133810043.
>
> CL 133820043 removed that allocation.
>
> Try again.
>
> Fixes issue 8405.
>
> Please review this at https://codereview.appspot.com/133830043/
>
> Affected files (+1, -1 lines):
>   M src/cmd/gc/subr.c
>
>
> Index: src/cmd/gc/subr.c
> ===================================================================
> --- a/src/cmd/gc/subr.c
> +++ b/src/cmd/gc/subr.c
> @@ -3808,7 +3808,7 @@
>         // where the data word can hold a pointer or any
>         // non-pointer value no bigger than a pointer.
>         enum {
> -               IfacePointerOnly = 0,
> +               IfacePointerOnly = 1,
>         };
>
>         if(IfacePointerOnly) {
>
>

[rsc, 2014-08-25 00:31:40]

*** Submitted as https://code.google.com/p/go/source/detail?r=cf7fe9f1fd36 ***

cmd/gc: re-enable IfacePointerOnly

CL 130240043 did this but broke ARM, because
it made newErrorCString start allocating, so we rolled
it back in CL 133810043.

CL 133820043 removed that allocation.

Try again.

Fixes issue 8405.

LGTM=bradfitz, dave
R=golang-codereviews, bradfitz
CC=dave, golang-codereviews, r
https://codereview.appspot.com/133830043