Code review - Issue 133830043: code review 133830043: cmd/gc: re-enable IfacePointerOnlyhttps://codereview.appspot.com/2014-08-25T00:31:40+00:00rietveld
Message from unknown
2014-08-24T02:04:34+00:00rscurn:md5:89c049a0790657279832e8c253d98722
Message from unknown
2014-08-24T02:04:38+00:00rscurn:md5:6c56cdbf18d768b44791cbe22dac7655
Message from unknown
2014-08-25T00:27:43+00:00rscurn:md5:0dd1123423a3d54f7d7b2eb24fcae313
Message from rsc@golang.org
2014-08-25T00:27:48+00:00rscurn:md5:ed3cf19290b1e1c84310a0b5dffc8a49
Hello golang-codereviews@googlegroups.com (cc: dfc, r),
I'd like you to review this change to
https://code.google.com/p/go/
Message from bradfitz@golang.org
2014-08-25T00:29:30+00:00bradfitzurn:md5:d08d5a91a81d227f112ac8c4564312ef
LGTM
On Aug 24, 2014 5:27 PM, <rsc@golang.org> wrote:
> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com (cc: dfc, r),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> cmd/gc: re-enable IfacePointerOnly
>
> CL 130240043 did this but broke ARM, because
> it made newErrorCString start allocating, so we rolled
> it back in CL 133810043.
>
> CL 133820043 removed that allocation.
>
> Try again.
>
> Fixes issue 8405.
>
> Please review this at https://codereview.appspot.com/133830043/
>
> Affected files (+1, -1 lines):
> M src/cmd/gc/subr.c
>
>
> Index: src/cmd/gc/subr.c
> ===================================================================
> --- a/src/cmd/gc/subr.c
> +++ b/src/cmd/gc/subr.c
> @@ -3808,7 +3808,7 @@
> // where the data word can hold a pointer or any
> // non-pointer value no bigger than a pointer.
> enum {
> - IfacePointerOnly = 0,
> + IfacePointerOnly = 1,
> };
>
> if(IfacePointerOnly) {
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
Message from dave@cheney.net
2014-08-25T00:29:34+00:00dfcurn:md5:8695164e445206cd8d3940820a6b3836
LGTM.
On Mon, Aug 25, 2014 at 10:27 AM, <rsc@golang.org> wrote:
> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com (cc: dfc, r),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> cmd/gc: re-enable IfacePointerOnly
>
> CL 130240043 did this but broke ARM, because
> it made newErrorCString start allocating, so we rolled
> it back in CL 133810043.
>
> CL 133820043 removed that allocation.
>
> Try again.
>
> Fixes issue 8405.
>
> Please review this at https://codereview.appspot.com/133830043/
>
> Affected files (+1, -1 lines):
> M src/cmd/gc/subr.c
>
>
> Index: src/cmd/gc/subr.c
> ===================================================================
> --- a/src/cmd/gc/subr.c
> +++ b/src/cmd/gc/subr.c
> @@ -3808,7 +3808,7 @@
> // where the data word can hold a pointer or any
> // non-pointer value no bigger than a pointer.
> enum {
> - IfacePointerOnly = 0,
> + IfacePointerOnly = 1,
> };
>
> if(IfacePointerOnly) {
>
>
Message from unknown
2014-08-25T00:31:32+00:00rscurn:md5:735e67f151b2121933820059e97c0499
Message from rsc@golang.org
2014-08-25T00:31:40+00:00rscurn:md5:8edbf73820a41058762d3e6ee2fad7f7
*** Submitted as https://code.google.com/p/go/source/detail?r=cf7fe9f1fd36 ***
cmd/gc: re-enable IfacePointerOnly
CL 130240043 did this but broke ARM, because
it made newErrorCString start allocating, so we rolled
it back in CL 133810043.
CL 133820043 removed that allocation.
Try again.
Fixes issue 8405.
LGTM=bradfitz, dave
R=golang-codereviews, bradfitz
CC=dave, golang-codereviews, r
https://codereview.appspot.com/133830043