Code review - Issue 98990043: code review 98990043: x86asm: instruction definitionhttps://codereview.appspot.com/2014-05-07T15:16:45+00:00rietveld
Message from unknown
2014-05-07T05:09:37+00:00rscurn:md5:f45430c6f48745bbf3a0b395e98c3a35
Message from unknown
2014-05-07T05:09:41+00:00rscurn:md5:f9e5c3d62fc8ed5fc14ea4ff1de95a1c
Message from unknown
2014-05-07T05:09:51+00:00rscurn:md5:14d335c0372c6b9cb76ee856c1fe624c
Message from rsc@golang.org
2014-05-07T05:09:55+00:00rscurn:md5:5fde0ae46015f8bb45e1f7b12c279b6f
Hello crawshaw,
I'd like you to review this change to
https://code.google.com/p/rsc.x86/
Message from crawshaw@golang.org
2014-05-07T13:14:06+00:00crawshawurn:md5:cee49d30e4ba1f503a174cbba0ee204e
LGTM
It would be easy to add a test that regNames is a complete mapping through to TR7.
https://codereview.appspot.com/98990043/diff/40001/x86asm/inst.go
File x86asm/inst.go (right):
https://codereview.appspot.com/98990043/diff/40001/x86asm/inst.go#newcode375
x86asm/inst.go:375: return fmt.Sprintf("$%#x", int64(i))
Do you really want a $ and 0x prefix?
Message from rsc@golang.org
2014-05-07T15:16:28+00:00rscurn:md5:b3adae6a948283be7b67f1cac7771c83
I added the test you suggested.
https://codereview.appspot.com/98990043/diff/40001/x86asm/inst.go
File x86asm/inst.go (right):
https://codereview.appspot.com/98990043/diff/40001/x86asm/inst.go#newcode375
x86asm/inst.go:375: return fmt.Sprintf("$%#x", int64(i))
On 2014/05/07 13:14:05, crawshaw wrote:
> Do you really want a $ and 0x prefix?
Since I'm generating pseudo-intel syntax, I guess you're right that I don't need the $ here.
($ means immediate for GNU and Plan 9 syntax, not hex.)
Message from unknown
2014-05-07T15:16:40+00:00rscurn:md5:f2a6808bc58ae5acb84e4f5ac85ce970
Message from rsc@golang.org
2014-05-07T15:16:45+00:00rscurn:md5:6e13ed3b5d9378e665283754b0a2bae5
*** Submitted as https://code.google.com/p/rsc/source/detail?r=8f07e70e2550&repo=x86 ***
x86asm: instruction definition
LGTM=crawshaw
R=crawshaw
https://codereview.appspot.com/98990043