Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(423)

Issue 9831043: code review 9831043: runtime: fix heap corruption during GC (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 2 months ago by dvyukov
Modified:
4 years, 2 months ago
Reviewers:
khr
CC:
golang-dev, khr
Visibility:
Public.

Description

runtime: fix heap corruption during GC The 'n' variable is used during rescan initiation in GC_END case, but it's overwritten with chan capacity in GC_CHAN case. As the result rescan is done with the wrong object size. Fixes issue 5554.

Patch Set 1 #

Patch Set 2 : diff -r e4db68a39f50 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r e4db68a39f50 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r e4db68a39f50 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Patch
M src/pkg/runtime/gc_test.go View 1 1 chunk +28 lines, -0 lines 0 comments Download
M src/pkg/runtime/mgc0.c View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
4 years, 2 months ago (2013-05-28 15:06:33 UTC) #1
khr
On 2013/05/28 15:06:33, dvyukov wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...
4 years, 2 months ago (2013-05-28 15:11:18 UTC) #2
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=e84e7204b01b *** runtime: fix heap corruption during GC The 'n' variable is ...
4 years, 2 months ago (2013-05-28 15:17:57 UTC) #3
dfc
4 years, 2 months ago (2013-05-29 00:54:24 UTC) #4
Great find, thank you. I will try to verify this fix backported to the
release.go1.1 branch.

On Wed, May 29, 2013 at 1:17 AM,  <dvyukov@google.com> wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=e84e7204b01b ***
>
>
> runtime: fix heap corruption during GC
> The 'n' variable is used during rescan initiation in GC_END case,
> but it's overwritten with chan capacity in GC_CHAN case.
> As the result rescan is done with the wrong object size.
> Fixes issue 5554.
>
> R=golang-dev, khr
> CC=golang-dev
> https://codereview.appspot.com/9831043
>
>
>
> https://codereview.appspot.com/9831043/
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted