Issue 9831043: code review 9831043: runtime: fix heap corruption during GC

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9831043: code review 9831043: runtime: fix heap corruption during GC (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by dvyukov

Modified:
11 years, 7 months ago

Reviewers:
khr

CC:
golang-dev, khr

Visibility:
Public.

Description

runtime: fix heap corruption during GC The 'n' variable is used during rescan initiation in GC_END case, but it's overwritten with chan capacity in GC_CHAN case. As the result rescan is done with the wrong object size. Fixes issue 5554.

Patch Set 1 #

Patch Set 2 : diff -r e4db68a39f50 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r e4db68a39f50 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r e4db68a39f50 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -4 lines)			Patch
	M	src/pkg/runtime/gc_test.go	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download
	M	src/pkg/runtime/mgc0.c	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

11 years, 7 months ago (2013-05-28 15:06:33 UTC) #1

khr

On 2013/05/28 15:06:33, dvyukov wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...

11 years, 7 months ago (2013-05-28 15:11:18 UTC) #2

dvyukov

*** Submitted as https://code.google.com/p/go/source/detail?r=e84e7204b01b *** runtime: fix heap corruption during GC The 'n' variable is ...

11 years, 7 months ago (2013-05-28 15:17:57 UTC) #3

dave_cheney.net

11 years, 7 months ago (2013-05-29 00:54:24 UTC) #4

Great find, thank you. I will try to verify this fix backported to the
release.go1.1 branch.

On Wed, May 29, 2013 at 1:17 AM,  <dvyukov@google.com> wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=e84e7204b01b ***
>
>
> runtime: fix heap corruption during GC
> The 'n' variable is used during rescan initiation in GC_END case,
> but it's overwritten with chan capacity in GC_CHAN case.
> As the result rescan is done with the wrong object size.
> Fixes issue 5554.
>
> R=golang-dev, khr
> CC=golang-dev
> https://codereview.appspot.com/9831043
>
>
>
> https://codereview.appspot.com/9831043/
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

Expand All Messages | Collapse All Messages