rpc/jsoncodec: optional logging

rpc/jsoncodec: optional logging

Because we're now using the same codec on
both client and server, we were seeing each message
logged twice when testing. This changes
things so we only log on the server side.

https://code.launchpad.net/~rogpeppe/juju-core/313-jsoncodec-optional-log/+merge/165736

Requires: https://code.launchpad.net/~rogpeppe/juju-core/312-api-jobs/+merge/165705

(do not edit description out of merge proposal)

[rog, 2013-05-25 08:12:42]

Please take a look.

[rog, 2013-05-25 13:34:39]

Please take a look.

[fwereade, 2013-05-27 20:29:44]

NOT LGTM I'm afraid.

https://codereview.appspot.com/9692044/diff/5002/rpc/jsoncodec/codec.go
File rpc/jsoncodec/codec.go (right):

https://codereview.appspot.com/9692044/diff/5002/rpc/jsoncodec/codec.go#newco...
rpc/jsoncodec/codec.go:44: // called before the codec is used for serving RPC
requests.
This is a timebomb that will explode as soon as we have dynamic logging levels,
and someone notices that the API server doesn't respect them. If you're going to
implement this, please do it properly...

[rog, 2013-06-07 17:46:39]

Please take a look.

https://codereview.appspot.com/9692044/diff/5002/rpc/jsoncodec/codec.go
File rpc/jsoncodec/codec.go (right):

https://codereview.appspot.com/9692044/diff/5002/rpc/jsoncodec/codec.go#newco...
rpc/jsoncodec/codec.go:44: // called before the codec is used for serving RPC
requests.
On 2013/05/27 20:29:44, fwereade wrote:
> This is a timebomb that will explode as soon as we have dynamic logging
levels,
> and someone notices that the API server doesn't respect them. If you're going
to
> implement this, please do it properly...

Done.

[fwereade, 2013-06-07 22:52:30]

LGTM, thanks.

[wallyworld, 2013-06-21 01:28:02]

LGTM

[rog, 2013-06-25 06:00:11]

On 2013/06/21 01:28:02, wallyworld wrote:
> LGTM

merged as https://codereview.appspot.com/10410046/