Issue 10410046: rpc/jsoncodec: optional logging

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10410046: rpc/jsoncodec: optional logging

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by rog

Modified:
10 years, 11 months ago

Reviewers:
mp+170258

Visibility:
Public.

Description

rpc/jsoncodec: optional logging Because we're now using the same codec on both client and server, we were seeing each message logged twice when testing. This changes things so we only log on the server side. [reproposal of https://codereview.appspot.com/9692044/] https://code.launchpad.net/~rogpeppe/juju-core/313-alt-jsoncodec-optional-log/+merge/170258 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : rpc/jsoncodec: optional logging #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+145 lines, -31 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	rpc/jsoncodec/codec.go	View	6 chunks	+31 lines, -17 lines	0 comments	Download
M	rpc/jsoncodec/codec_test.go	View	5 chunks	+104 lines, -10 lines	0 comments	Download
M	rpc/jsoncodec/conn.go	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	state/apiserver/apiserver.go	View	2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Please take a look.

Expand All Messages | Collapse All Messages