Issue 9644044: code review 9644044: undo CL 9658043 / ac7877558dce

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9644044: code review 9644044: undo CL 9658043 / ac7877558dce (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by r

Modified:
12 years, 1 month ago

Reviewers:
iant

CC:
golang-dev, iant

Visibility:
Public.

Description

undo CL 9658043 / ac7877558dce The original code was correct. The count returned must be the length of the input slice, not the length of the formatted message. ««« original CL description log/syslog: report errors from Fprintf Thanks to chiparus for identifying this. Fixes issue 5541. R=golang-dev, iant CC=golang-dev https://codereview.appspot.com/9658043 »»»

Patch Set 1 #

Patch Set 2 : diff -r 469353116d53 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 469353116d53 https://code.google.com/p/go/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/pkg/log/syslog/syslog.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 1 month ago (2013-05-22 18:38:49 UTC) #1

12 years, 1 month ago (2013-05-22 18:42:08 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=66517e57fb48 ***

undo CL 9658043 / ac7877558dce

The original code was correct. The count returned must be the length
of the input slice, not the length of the formatted message.

««« original CL description
log/syslog: report errors from Fprintf
Thanks to chiparus for identifying this.

Fixes issue 5541.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/9658043
»»»

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/9644044

Expand All Messages | Collapse All Messages