code review 9658043: log/syslog: report errors from Fprintf

log/syslog: report errors from Fprintf
Thanks to chiparus for identifying this.

Fixes issue 5541.

[r, 2013-05-22 17:44:32]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[iant, 2013-05-22 17:59:01]

LGTM

[r, 2013-05-22 18:03:17]

*** Submitted as https://code.google.com/p/go/source/detail?r=ac7877558dce ***

log/syslog: report errors from Fprintf
Thanks to chiparus for identifying this.

Fixes issue 5541.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/9658043

[bradfitz, 2013-05-22 18:15:54]

I don't think this is correct.

It violates the io.Writer contract, returning written n > len(p []byte).




On Wed, May 22, 2013 at 11:03 AM, <r@golang.org> wrote:

> *** Submitted as
>
https://code.google.com/p/go/**source/detail?r=ac7877558dce<https://code.goog...
>
>
> log/syslog: report errors from Fprintf
> Thanks to chiparus for identifying this.
>
> Fixes issue 5541.
>
> R=golang-dev, iant
> CC=golang-dev
>
https://codereview.appspot.**com/9658043<https://codereview.appspot.com/9658043>
>
>
>
>
https://codereview.appspot.**com/9658043/<https://codereview.appspot.com/9658...
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[r, 2013-05-22 18:25:03]

You're right. Reverting. The issue I was trying to fix was invalid.

-rob

[bradfitz, 2013-05-22 18:27:09]

Could it do:

_, err := fmt.Fprintf(...)
if err != nil {
    return 0, err
}
return len(p), nil

?



On Wed, May 22, 2013 at 11:24 AM, Rob Pike <r@golang.org> wrote:

> You're right. Reverting. The issue I was trying to fix was invalid.
>
> -rob
>

[r, 2013-05-22 18:30:32]

Yes, that's what I'll do after the rollback.

On Wed, May 22, 2013 at 11:27 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> Could it do:
>
> _, err := fmt.Fprintf(...)
> if err != nil {
>     return 0, err
> }
> return len(p), nil
>
> ?
>
>
>
> On Wed, May 22, 2013 at 11:24 AM, Rob Pike <r@golang.org> wrote:
>>
>> You're right. Reverting. The issue I was trying to fix was invalid.
>>
>> -rob
>
>