Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2047)

Issue 96410045: code review 96410045: undo CL 69070045 / 8539a916d98a (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by rsc
Modified:
9 years, 11 months ago
Reviewers:
r
CC:
rsc, eaburns
Visibility:
Public.

Description

undo CL 69070045 / 8539a916d98a This breaks ^C in win windows, as expected. People use ^C, win expects and handles ^C, so I don't think we can just take it away. I've noticed that it is broken but assumed my ssh was screwed up. If you want to make WindowsKey+C,X,V do the operations, by analogy with command+C,X,V on Mac, that's fine with me. ««« original CL description acme: copy/cut/paste with ctl+c,x,v LGTM=rsc R=rsc CC=plan9port.codebot https://codereview.appspot.com/69070045 Committer: Russ Cox <rsc@swtch.com> »»»

Patch Set 1 #

Patch Set 2 : diff -r 9ca2936e82d4 https://code.google.com/p/plan9port #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/cmd/acme/text.c View 1 3 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello rsc (cc: burns.ethan@gmail.com, r@golang.org), I'd like you to review this change to https://code.google.com/p/plan9port
9 years, 11 months ago (2014-05-19 13:39:32 UTC) #1
rsc
*** Submitted as https://code.google.com/p/plan9port/source/detail?r=ed3ca4576def *** undo CL 69070045 / 8539a916d98a This breaks ^C in win ...
9 years, 11 months ago (2014-05-19 13:39:38 UTC) #2
r
LGTM
9 years, 11 months ago (2014-05-19 15:03:21 UTC) #3
eaburns
We knew that this change would break ^C in win, but I thought you agreed ...
9 years, 11 months ago (2014-05-19 15:54:10 UTC) #4
rsc
9 years, 11 months ago (2014-05-19 15:58:08 UTC) #5
On Mon, May 19, 2014 at 11:54 AM, Ethan Burns <burns.ethan@gmail.com> wrote:

> We knew that this change would break ^C in win, but I thought you agreed
> that it was acceptable since del still works fine.
>

I didn't realize how much I and others typed ^C. I don't think we can break
Macs to make Linux happy. And even Linux users type ^C.

Russ
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b