code review 9416047: cmd/go: fix LDFLAGS handling, enable misc/cgo/testso on...

cmd/go: fix LDFLAGS handling, enable misc/cgo/testso on Darwin
Fixes issue 5479.

[minux1, 2013-05-20 22:10:30]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[dave_cheney.net, 2013-05-21 11:02:16]

LGTM. Tested on darwin/amd64, 10.7.4.

[minux1, 2013-05-21 16:32:17]

*** Submitted as https://code.google.com/p/go/source/detail?r=75123d9d5b96 ***

cmd/go: fix LDFLAGS handling, enable misc/cgo/testso on Darwin
Fixes issue 5479.

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/9416047

[capnm, 2013-05-24 01:04:09]

On 2013/05/21 16:32:17, minux wrote:
> *** Submitted as https://code.google.com/p/go/source/detail?r=75123d9d5b96 ***
> 
> cmd/go: fix LDFLAGS handling, enable misc/cgo/testso on Darwin
> Fixes issue 5479.
> 
> R=golang-dev, dave
> CC=golang-dev
> https://codereview.appspot.com/9416047

Accidentally found this in the test output:

# ../misc/cgo/testso
./test.bash: 11: [: Linux: unexpected operator

sh (what ever it is on ubuntu) doesn't know ==

[dave_cheney.net, 2013-05-24 01:46:56]

Given that file name ends in .bash, the simplest solution would be to
upgrade the shbang line to bash. Do you want to propose a CL ?

On Fri, May 24, 2013 at 11:04 AM,  <capnm9@gmail.com> wrote:
> On 2013/05/21 16:32:17, minux wrote:
>>
>> *** Submitted as
>
> https://code.google.com/p/go/source/detail?r=75123d9d5b96 ***
>
>> cmd/go: fix LDFLAGS handling, enable misc/cgo/testso on Darwin
>> Fixes issue 5479.
>
>
>> R=golang-dev, dave
>> CC=golang-dev
>> https://codereview.appspot.com/9416047
>
>
> Accidentally found this in the test output:
>
> # ../misc/cgo/testso
> ./test.bash: 11: [: Linux: unexpected operator
>
> sh (what ever it is on ubuntu) doesn't know ==
>
>
> https://codereview.appspot.com/9416047/

[minux1, 2013-05-24 07:43:07]

On Friday, May 24, 2013, wrote:

> On 2013/05/21 16:32:17, minux wrote:
>
>> *** Submitted as
>>
>
https://code.google.com/p/go/**source/detail?r=75123d9d5b96<https://code.goog...
>
>  cmd/go: fix LDFLAGS handling, enable misc/cgo/testso on Darwin
>> Fixes issue 5479.
>>
>
>  R=golang-dev, dave
>> CC=golang-dev
>>
https://codereview.appspot.**com/9416047<https://codereview.appspot.com/9416047>
>>
>
> Accidentally found this in the test output:
>
> # ../misc/cgo/testso
> ./test.bash: 11: [: Linux: unexpected operator
>
> sh (what ever it is on ubuntu) doesn't know ==
>
ah, bashism, my bad.
we can switch the shebang line or s/==/=/ in this line.
as dave said, the first solution might be more preferable.

do you want to propose a CL?

[dave_cheney.net, 2013-05-24 08:07:41]

https://codereview.appspot.com/9717043

It was hard to find a machine where /bin/sh was not bash (or dash, or
whatever the problem child was)

On Fri, May 24, 2013 at 5:43 PM, minux <minux.ma@gmail.com> wrote:
>
> On Friday, May 24, 2013, wrote:
>>
>> On 2013/05/21 16:32:17, minux wrote:
>>>
>>> *** Submitted as
>>
>> https://code.google.com/p/go/source/detail?r=75123d9d5b96 ***
>>
>>> cmd/go: fix LDFLAGS handling, enable misc/cgo/testso on Darwin
>>> Fixes issue 5479.
>>
>>
>>> R=golang-dev, dave
>>> CC=golang-dev
>>> https://codereview.appspot.com/9416047
>>
>>
>> Accidentally found this in the test output:
>>
>> # ../misc/cgo/testso
>> ./test.bash: 11: [: Linux: unexpected operator
>>
>> sh (what ever it is on ubuntu) doesn't know ==
>
> ah, bashism, my bad.
> we can switch the shebang line or s/==/=/ in this line.
> as dave said, the first solution might be more preferable.
>
> do you want to propose a CL?

[capnm, 2013-05-24 08:55:23]

On 24 May 2013 10:07, Dave Cheney <dave@cheney.net> wrote:

> https://codereview.appspot.com/9717043
>
> It was hard to find a machine where /bin/sh was not bash (or dash, or
> whatever the problem child was)
>
>
cat /etc/lsb-release
DISTRIB_DESCRIPTION="Ubuntu 13.04"

ls -all /bin/sh
lrwxrwxrwx 1 root root 4 Mai 13 16:39 /bin/sh -> dash

pi@rpi $ ls -all /bin/sh
lrwxrwxrwx 1 root root 4 Mär 30  2012 /bin/sh -> dash

It seems to be the default on debian based distributions.

[dave_cheney.net, 2013-05-24 09:04:21]

Interestingly I could _not_ reproduce the problem in amd64 Ubuntu 13.04.  

But could reproduce the problem on 386 Ubuntu 12.04.1

Either way, the sh env is now consistent with the file extension. 

On 24/05/2013, at 18:55, Martin Capitanio <capnm9@gmail.com> wrote:

> On 24 May 2013 10:07, Dave Cheney <dave@cheney.net> wrote:
>> https://codereview.appspot.com/9717043
>> 
>> It was hard to find a machine where /bin/sh was not bash (or dash, or
>> whatever the problem child was)
> 
> cat /etc/lsb-release 
> DISTRIB_DESCRIPTION="Ubuntu 13.04"
> 
> ls -all /bin/sh
> lrwxrwxrwx 1 root root 4 Mai 13 16:39 /bin/sh -> dash
> 
> pi@rpi $ ls -all /bin/sh
> lrwxrwxrwx 1 root root 4 Mär 30  2012 /bin/sh -> dash
> 
> It seems to be the default on debian based distributions.