Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(67)

Issue 9717043: code review 9717043: misc/cgo/testso: use bash to run test.bash (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by dave
Modified:
11 years ago
Reviewers:
minux1, capnm
CC:
golang-dev, minux1, capnm
Visibility:
Public.

Description

misc/cgo/testso: use bash to run test.bash

Patch Set 1 #

Patch Set 2 : code review 9717043: misc/cgo/testso: use bash to run test.bash #

Patch Set 3 : diff -r bb012ad2fa67 https://code.google.com/p/go #

Patch Set 4 : diff -r 0a4f424db1e2 https://code.google.com/p/go #

Patch Set 5 : diff -r 0a4f424db1e2 https://code.google.com/p/go #

Patch Set 6 : diff -r d6e06d0f3c29 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M misc/cgo/testso/test.bash View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
dave_cheney.net
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years ago (2013-05-24 08:07:09 UTC) #1
minux1
Please use #!/usr/bin/env bash like the others, and then LGTM. On Friday, May 24, 2013, ...
11 years ago (2013-05-24 08:10:36 UTC) #2
dave_cheney.net
Hello golang-dev@googlegroups.com, minux.ma@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
11 years ago (2013-05-24 08:18:20 UTC) #3
minux1
LGTM. Thank you.
11 years ago (2013-05-24 08:19:35 UTC) #4
capnm
LGTM
11 years ago (2013-05-24 08:55:44 UTC) #5
dave_cheney.net
11 years ago (2013-05-24 11:58:34 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=bcd566b5492c ***

misc/cgo/testso: use bash to run test.bash

R=golang-dev, minux.ma, capnm9
CC=golang-dev
https://codereview.appspot.com/9717043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b