Please use #!/usr/bin/env bash like the others, and then LGTM. On Friday, May 24, 2013, ...
11 years, 12 months ago
(2013-05-24 08:10:36 UTC)
#2
Please use #!/usr/bin/env bash like the others, and then LGTM.
On Friday, May 24, 2013, wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> misc/cgo/testso: use bash to run test.bash
>
> Please review this at
https://codereview.appspot.**com/9717043/<https://codereview.appspot.com/9717...
>
> Affected files:
> M misc/cgo/testso/test.bash
>
>
> Index: misc/cgo/testso/test.bash
> ==============================**==============================**=======
> --- a/misc/cgo/testso/test.bash
> +++ b/misc/cgo/testso/test.bash
> @@ -1,4 +1,4 @@
> -#!/bin/sh
> +#!/bin/bash
> # Copyright 2011 The Go Authors. All rights reserved.
> # Use of this source code is governed by a BSD-style
> # license that can be found in the LICENSE file.
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>
*** Submitted as https://code.google.com/p/go/source/detail?r=bcd566b5492c *** misc/cgo/testso: use bash to run test.bash R=golang-dev, minux.ma, capnm9 CC=golang-dev ...
11 years, 12 months ago
(2013-05-24 11:58:34 UTC)
#6
Issue 9717043: code review 9717043: misc/cgo/testso: use bash to run test.bash
(Closed)
Created 11 years, 12 months ago by dave_cheney.net
Modified 11 years, 12 months ago
Reviewers:
Base URL:
Comments: 0