Issue 93290043: code review 93290043: upas: fix warnings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 93290043: code review 93290043: upas: fix warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by 0intro

Modified:
10 years, 5 months ago

Reviewers:
rsc

CC:
rsc

Visibility:
Public.

Description

upas: fix warnings smtp.c:232: warning: comparison with string literal results in unspecified behavior smtp.c:244: warning: comparison with string literal results in unspecified behavior marshal.c:1179: warning: variable ‘err’ set but not used

Patch Set 1 #

Patch Set 2 : diff -r 9bfe12150c5e https://code.google.com/p/plan9port/ #

Patch Set 3 : diff -r 6bfe553f1b0f https://code.google.com/p/plan9port/ #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/cmd/upas/marshal/marshal.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/cmd/upas/smtp/smtp.c	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

0intro

Hello rsc, I'd like you to review this change to https://code.google.com/p/plan9port/

10 years, 5 months ago (2014-05-12 20:41:14 UTC) #1

0intro

10 years, 5 months ago (2014-05-15 04:29:31 UTC) #3

*** Submitted as
https://code.google.com/p/plan9port/source/detail?r=9ca2936e82d4 ***

upas: fix warnings

smtp.c:232: warning: comparison with string literal results in unspecified
behavior
smtp.c:244: warning: comparison with string literal results in unspecified
behavior
marshal.c:1179: warning: variable ‘err’ set but not used

LGTM=rsc
R=rsc
https://codereview.appspot.com/93290043

Expand All Messages | Collapse All Messages