Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10)

Issue 93290043: code review 93290043: upas: fix warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 1 month ago by 0intro
Modified:
8 years, 1 month ago
Reviewers:
rsc
CC:
rsc
Visibility:
Public.

Description

upas: fix warnings smtp.c:232: warning: comparison with string literal results in unspecified behavior smtp.c:244: warning: comparison with string literal results in unspecified behavior marshal.c:1179: warning: variable ‘err’ set but not used

Patch Set 1 #

Patch Set 2 : diff -r 9bfe12150c5e https://code.google.com/p/plan9port/ #

Patch Set 3 : diff -r 6bfe553f1b0f https://code.google.com/p/plan9port/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/cmd/upas/marshal/marshal.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/upas/smtp/smtp.c View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
0intro
Hello rsc, I'd like you to review this change to https://code.google.com/p/plan9port/
8 years, 1 month ago (2014-05-12 20:41:14 UTC) #1
rsc
LGTM
8 years, 1 month ago (2014-05-15 01:38:33 UTC) #2
0intro
8 years, 1 month ago (2014-05-15 04:29:31 UTC) #3
*** Submitted as
https://code.google.com/p/plan9port/source/detail?r=9ca2936e82d4 ***

upas: fix warnings

smtp.c:232: warning: comparison with string literal results in unspecified
behavior
smtp.c:244: warning: comparison with string literal results in unspecified
behavior
marshal.c:1179: warning: variable ‘err’ set but not used

LGTM=rsc
R=rsc
https://codereview.appspot.com/93290043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b