code review 91840044: all: spelling tweaks, A-G

all: spelling tweaks, A-G

[rh, 2014-04-28 01:32:54]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2014-04-28 01:35:37]

The convention is to prefix these global changes with "all: " in the CL
subject.
 On Apr 27, 2014 9:32 PM, <robert.hencke@gmail.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> pkg: speling tweaks, A-G
>
> Please review this at https://codereview.appspot.com/91840044/
>
> Affected files (+120, -119 lines):
>   M src/cmd/cgo/out.go
>   M src/pkg/archive/tar/example_test.go
>   M src/pkg/archive/tar/reader_test.go
>   M src/pkg/archive/tar/writer.go
>   M src/pkg/archive/zip/example_test.go
>   M src/pkg/bufio/bufio.go
>   M src/pkg/bufio/bufio_test.go
>   M src/pkg/bufio/scan.go
>   M src/pkg/bufio/scan_test.go
>   M src/pkg/bytes/bytes_test.go
>   M src/pkg/bytes/compare_test.go
>   M src/pkg/compress/bzip2/bzip2_test.go
>   M src/pkg/compress/flate/fixedhuff.go
>   M src/pkg/compress/flate/gen.go
>   M src/pkg/compress/flate/inflate.go
>   M src/pkg/compress/flate/reader_test.go
>   M src/pkg/compress/zlib/writer_test.go
>   M src/pkg/container/list/list_test.go
>   M src/pkg/crypto/cipher/benchmark_test.go
>   M src/pkg/crypto/des/const.go
>   M src/pkg/crypto/md5/md5_test.go
>   M src/pkg/crypto/rsa/pkcs1v15.go
>   M src/pkg/crypto/rsa/pss.go
>   M src/pkg/crypto/rsa/rsa.go
>   M src/pkg/crypto/sha1/sha1_test.go
>   M src/pkg/crypto/sha256/sha256_test.go
>   M src/pkg/crypto/sha512/sha512_test.go
>   M src/pkg/crypto/subtle/constant_time_test.go
>   M src/pkg/crypto/tls/cipher_suites.go
>   M src/pkg/crypto/tls/common.go
>   M src/pkg/crypto/tls/conn.go
>   M src/pkg/crypto/tls/handshake_client.go
>   M src/pkg/crypto/tls/handshake_messages_test.go
>   M src/pkg/crypto/tls/handshake_server.go
>   M src/pkg/crypto/tls/handshake_server_test.go
>   M src/pkg/crypto/tls/key_agreement.go
>   M src/pkg/crypto/tls/prf.go
>   M src/pkg/crypto/x509/root_darwin_test.go
>   M src/pkg/crypto/x509/verify.go
>   M src/pkg/crypto/x509/x509.go
>   M src/pkg/crypto/x509/x509_test.go
>   M src/pkg/database/sql/fakedb_test.go
>   M src/pkg/database/sql/sql.go
>   M src/pkg/database/sql/sql_test.go
>   M src/pkg/debug/elf/elf.go
>   M src/pkg/debug/goobj/read.go
>   M src/pkg/encoding/asn1/asn1.go
>   M src/pkg/encoding/asn1/asn1_test.go
>   M src/pkg/encoding/asn1/marshal.go
>   M src/pkg/encoding/base32/base32_test.go
>   M src/pkg/encoding/base64/base64_test.go
>   M src/pkg/encoding/gob/encoder_test.go
>   M src/pkg/encoding/json/bench_test.go
>   M src/pkg/encoding/json/decode.go
>   M src/pkg/encoding/xml/read_test.go
>   M src/pkg/encoding/xml/xml.go
>   M src/pkg/expvar/expvar.go
>   M src/pkg/fmt/doc.go
>   M src/pkg/fmt/fmt_test.go
>   M src/pkg/fmt/format.go
>   M src/pkg/fmt/scan.go
>   M src/pkg/fmt/scan_test.go
>   M src/pkg/go/ast/commentmap.go
>   M src/pkg/go/build/build_test.go
>   M src/pkg/go/doc/comment.go
>   M src/pkg/go/doc/example.go
>   M src/pkg/go/doc/testdata/a.0.golden
>   M src/pkg/go/doc/testdata/a.1.golden
>   M src/pkg/go/doc/testdata/a.2.golden
>   M src/pkg/go/doc/testdata/a0.go
>   M src/pkg/go/parser/parser.go
>   M src/pkg/go/printer/nodes.go
>   M src/pkg/go/printer/printer.go
>   M src/pkg/go/printer/printer_test.go
>   M src/pkg/go/printer/testdata/linebreaks.golden
>   M src/pkg/go/printer/testdata/linebreaks.input
>   M src/pkg/go/printer/testdata/parser.go
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[rh, 2014-04-28 01:37:32]

Hello golang-codereviews@googlegroups.com, bradfitz@golang.org (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[ruiu, 2014-04-28 01:54:04]

It looks to me that this patch changed too many hyphenations where the original
words were not wrong. I'd rather not change them.

https://codereview.appspot.com/91840044/diff/140002/src/pkg/compress/zlib/wri...
File src/pkg/compress/zlib/writer_test.go (right):

https://codereview.appspot.com/91840044/diff/140002/src/pkg/compress/zlib/wri...
src/pkg/compress/zlib/writer_test.go:123: // Reset and compresses again.
compress

https://codereview.appspot.com/91840044/diff/140002/src/pkg/database/sql/fake...
File src/pkg/database/sql/fakedb_test.go (right):

https://codereview.appspot.com/91840044/diff/140002/src/pkg/database/sql/fake...
src/pkg/database/sql/fakedb_test.go:327: // errf is a sound of frustration
This is not a spelling fix.

https://codereview.appspot.com/91840044/diff/140002/src/pkg/encoding/asn1/asn...
File src/pkg/encoding/asn1/asn1_test.go (right):

https://codereview.appspot.com/91840044/diff/140002/src/pkg/encoding/asn1/asn...
src/pkg/encoding/asn1/asn1_test.go:494: // This is the Paypal NUL-hack
certificate. It should fail to parse because
To me "paypal" is okay but if you change this this should be "PayPal".

https://codereview.appspot.com/91840044/diff/140002/src/pkg/fmt/doc.go
File src/pkg/fmt/doc.go (right):

https://codereview.appspot.com/91840044/diff/140002/src/pkg/fmt/doc.go#newcode94
src/pkg/fmt/doc.go:94: for %q, print a raw (back-quoted) string if
strconv.CanBackquote
"backquote" seemed better than "back-quote".

[bradfitz, 2014-04-28 01:55:11]

Yes, please keep this minimal. If in doubt, don't change it.
 On Apr 27, 2014 9:54 PM, <ruiu@google.com> wrote:

> It looks to me that this patch changed too many hyphenations where the
> original words were not wrong. I'd rather not change them.
>
>
> https://codereview.appspot.com/91840044/diff/140002/src/
> pkg/compress/zlib/writer_test.go
> File src/pkg/compress/zlib/writer_test.go (right):
>
> https://codereview.appspot.com/91840044/diff/140002/src/
> pkg/compress/zlib/writer_test.go#newcode123
> src/pkg/compress/zlib/writer_test.go:123: // Reset and compresses again.
> compress
>
> https://codereview.appspot.com/91840044/diff/140002/src/
> pkg/database/sql/fakedb_test.go
> File src/pkg/database/sql/fakedb_test.go (right):
>
> https://codereview.appspot.com/91840044/diff/140002/src/
> pkg/database/sql/fakedb_test.go#newcode327
> src/pkg/database/sql/fakedb_test.go:327: // errf is a sound of
> frustration
> This is not a spelling fix.
>
> https://codereview.appspot.com/91840044/diff/140002/src/
> pkg/encoding/asn1/asn1_test.go
> File src/pkg/encoding/asn1/asn1_test.go (right):
>
> https://codereview.appspot.com/91840044/diff/140002/src/
> pkg/encoding/asn1/asn1_test.go#newcode494
> src/pkg/encoding/asn1/asn1_test.go:494: // This is the Paypal NUL-hack
> certificate. It should fail to parse because
> To me "paypal" is okay but if you change this this should be "PayPal".
>
> https://codereview.appspot.com/91840044/diff/140002/src/pkg/fmt/doc.go
> File src/pkg/fmt/doc.go (right):
>
> https://codereview.appspot.com/91840044/diff/140002/src/
> pkg/fmt/doc.go#newcode94
> src/pkg/fmt/doc.go:94: for %q, print a raw (back-quoted) string if
> strconv.CanBackquote
> "backquote" seemed better than "back-quote".
>
> https://codereview.appspot.com/91840044/
>

[rh, 2014-04-28 02:20:59]

I have stripped out all the changes I wasn't fully certain about. PTAL

https://codereview.appspot.com/91840044/diff/140002/src/pkg/compress/zlib/wri...
File src/pkg/compress/zlib/writer_test.go (right):

https://codereview.appspot.com/91840044/diff/140002/src/pkg/compress/zlib/wri...
src/pkg/compress/zlib/writer_test.go:123: // Reset and compresses again.
On 2014/04/28 01:54:05, ruiu wrote:
> compress

Done.

https://codereview.appspot.com/91840044/diff/140002/src/pkg/database/sql/fake...
File src/pkg/database/sql/fakedb_test.go (right):

https://codereview.appspot.com/91840044/diff/140002/src/pkg/database/sql/fake...
src/pkg/database/sql/fakedb_test.go:327: // errf is a sound of frustration
On 2014/04/28 01:54:05, ruiu wrote:
> This is not a spelling fix.

Removed.

https://codereview.appspot.com/91840044/diff/140002/src/pkg/encoding/asn1/asn...
File src/pkg/encoding/asn1/asn1_test.go (right):

https://codereview.appspot.com/91840044/diff/140002/src/pkg/encoding/asn1/asn...
src/pkg/encoding/asn1/asn1_test.go:494: // This is the Paypal NUL-hack
certificate. It should fail to parse because
On 2014/04/28 01:54:05, ruiu wrote:
> To me "paypal" is okay but if you change this this should be "PayPal".

Whoops - thanks. Done.

https://codereview.appspot.com/91840044/diff/140002/src/pkg/fmt/doc.go
File src/pkg/fmt/doc.go (right):

https://codereview.appspot.com/91840044/diff/140002/src/pkg/fmt/doc.go#newcode94
src/pkg/fmt/doc.go:94: for %q, print a raw (back-quoted) string if
strconv.CanBackquote
On 2014/04/28 01:54:05, ruiu wrote:
> "backquote" seemed better than "back-quote".
Done.

[rh, 2014-04-28 02:30:57]

(for dashboard)
PTAL

[ruiu, 2014-04-28 03:05:25]

LGTM with the following change, but please wait for other reviewer to sign off.

https://codereview.appspot.com/91840044/diff/40002/src/pkg/crypto/tls/handsha...
File src/pkg/crypto/tls/handshake_messages_test.go (right):

https://codereview.appspot.com/91840044/diff/40002/src/pkg/crypto/tls/handsha...
src/pkg/crypto/tls/handshake_messages_test.go:69: // have parseable prefixes
because the extension
Not sure which is correct, parsable or parseable, so I'd rather keep it.

[rh, 2014-04-28 11:09:39]

PTAL

https://codereview.appspot.com/91840044/diff/40002/src/pkg/crypto/tls/handsha...
File src/pkg/crypto/tls/handshake_messages_test.go (right):

https://codereview.appspot.com/91840044/diff/40002/src/pkg/crypto/tls/handsha...
src/pkg/crypto/tls/handshake_messages_test.go:69: // have parseable prefixes
because the extension
On 2014/04/28 03:05:26, ruiu wrote:
> Not sure which is correct, parsable or parseable, so I'd rather keep it.

Done.

[bradfitz, 2014-04-28 16:43:56]

Sorry, this is still too editorial.

You're not fixing typos, you're doing stuff like changing valid British
English spellings to American English, and changing stuff like:

- // randomish but deterministic data
+ // pseudorandom data

There's enough other stuff to do right now to deal with reviewing this.

This is not minimal.




On Mon, Apr 28, 2014 at 4:09 AM, <robert.hencke@gmail.com> wrote:

> PTAL
>
>
>
> https://codereview.appspot.com/91840044/diff/40002/src/
> pkg/crypto/tls/handshake_messages_test.go
> File src/pkg/crypto/tls/handshake_messages_test.go (right):
>
> https://codereview.appspot.com/91840044/diff/40002/src/
> pkg/crypto/tls/handshake_messages_test.go#newcode69
> src/pkg/crypto/tls/handshake_messages_test.go:69: // have parseable
> prefixes because the extension
> On 2014/04/28 03:05:26, ruiu wrote:
>
>> Not sure which is correct, parsable or parseable, so I'd rather keep
>>
> it.
>
> Done.
>
> https://codereview.appspot.com/91840044/
>

[rh, 2014-04-28 16:56:06]

On 2014/04/28 16:43:56, bradfitz wrote:
> Sorry, this is still too editorial.
> You're not fixing typos, you're doing stuff like changing valid British
> English spellings to American English...

https://codereview.appspot.com/4536063 accepted changing British spellings to
American spellings.
It is not intended to be editorial, just consistent.

> There's enough other stuff to do right now to deal with reviewing this.

I'll close this and let you focus on those.

[bradfitz, 2014-04-28 17:00:33]

No need to close it. Just asking for it to be smaller.

If it's a real typo (especially user-visible in docs) then that's great to
fix.  If it's a Britishism in a unit test, I could care less.



On Mon, Apr 28, 2014 at 9:56 AM, <robert.hencke@gmail.com> wrote:

> On 2014/04/28 16:43:56, bradfitz wrote:
>
>> Sorry, this is still too editorial.
>> You're not fixing typos, you're doing stuff like changing valid
>>
> British
>
>> English spellings to American English...
>>
>
> https://codereview.appspot.com/4536063 accepted changing British
> spellings to American spellings.
> It is not intended to be editorial, just consistent.
>
>
>  There's enough other stuff to do right now to deal with reviewing
>>
> this.
>
> I'll close this and let you focus on those.
>
> https://codereview.appspot.com/91840044/
>

[rh, 2014-04-28 17:29:31]

OK. I'll pare this down to typos in comments only tonight.

On Monday, April 28, 2014, Brad Fitzpatrick <bradfitz@golang.org> wrote:

> No need to close it. Just asking for it to be smaller.
>
> If it's a real typo (especially user-visible in docs) then that's great to
> fix.  If it's a Britishism in a unit test, I could care less.
>
>
>
> On Mon, Apr 28, 2014 at 9:56 AM,
<robert.hencke@gmail.com<javascript:_e(%7B%7D,'cvml','robert.hencke@gmail.com');>
> > wrote:
>
>> On 2014/04/28 16:43:56, bradfitz wrote:
>>
>>> Sorry, this is still too editorial.
>>> You're not fixing typos, you're doing stuff like changing valid
>>>
>> British
>>
>>> English spellings to American English...
>>>
>>
>> https://codereview.appspot.com/4536063 accepted changing British
>> spellings to American spellings.
>> It is not intended to be editorial, just consistent.
>>
>>
>>  There's enough other stuff to do right now to deal with reviewing
>>>
>> this.
>>
>> I'll close this and let you focus on those.
>>
>> https://codereview.appspot.com/91840044/
>>
>
>

[rh, 2014-04-28 22:23:29]

Hello golang-codereviews@googlegroups.com, bradfitz@golang.org, ruiu@google.com
(cc: golang-codereviews@googlegroups.com),

Please take another look.

[bradfitz, 2014-04-29 16:43:20]

LGTM



On Mon, Apr 28, 2014 at 3:23 PM, <robert.hencke@gmail.com> wrote:

> Hello golang-codereviews@googlegroups.com, bradfitz@golang.org,
> ruiu@google.com (cc: golang-codereviews@googlegroups.com),
>
> Please take another look.
>
>
> https://codereview.appspot.com/91840044/
>

[bradfitz, 2014-04-29 16:44:45]

*** Submitted as https://code.google.com/p/go/source/detail?r=e91434717f12 ***

all: spelling tweaks, A-G

LGTM=ruiu, bradfitz
R=golang-codereviews, bradfitz, ruiu
CC=golang-codereviews
https://codereview.appspot.com/91840044

Committer: Brad Fitzpatrick <bradfitz@golang.org>