code review 4536063: pkg: spelling tweaks, A-H

pkg: spelling tweaks, A-H

[rh, 2011-05-17 07:24:41]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[ality, 2011-05-17 07:47:59]

LGTM aside from the one nit below.  Just curious,
did you do this by hand or was it automated?

http://codereview.appspot.com/4536063/diff/4001/src/pkg/debug/proc/proc_linux.go
File src/pkg/debug/proc/proc_linux.go (right):

http://codereview.appspot.com/4536063/diff/4001/src/pkg/debug/proc/proc_linux...
src/pkg/debug/proc/proc_linux.go:1217: // this process could be a flesh-eating
zombie.
Our zombies aren't flesh-eating.

[bradfitz, 2011-05-17 14:06:01]

On Tue, May 17, 2011 at 12:47 AM, <ality@pbrane.org> wrote:

> LGTM aside from the one nit below.  Just curious,
> did you do this by hand or was it automated?
>
>
>
>
http://codereview.appspot.com/4536063/diff/4001/src/pkg/debug/proc/proc_linux.go
> File src/pkg/debug/proc/proc_linux.go (right):
>
>
>
http://codereview.appspot.com/4536063/diff/4001/src/pkg/debug/proc/proc_linux...
> src/pkg/debug/proc/proc_linux.go:1217: // this process could be a
> flesh-eating zombie.
> Our zombies aren't flesh-eating.


The conspiracy theorist in me says that this whole CL was a means to get the
flesh-eating zombie reference in.  :-)

That aside, nice!

[rsc, 2011-05-17 14:56:58]

LGTM except the zombies

What did you use to find these?
I am impressed that you found errors in mixedCaps words
and also found loose -> lose.

Russ

[rh, 2011-05-18 01:27:05]

It is good to know that Go does not suffer the flesh-eating zombies that plague
other programming languages.

No conspiracy, just sleep-deprived humor.

I used grep, the Mac OS X spellchecker, and elbow grease.

The operating system's spellchecker will split apart mixedCaps and
underscore_separated compound words to spellcheck them.  So,
ThisIsSpelledCorrectly, as_is_this, but ThissIsNot.  This works well with the
custom dictionary: by defining "func" as a word, ColorFunc is considered to be
spelled correctly, but CollorFunc is not.

The process used was to open each file and proofread text, mostly focusing on
words the spellchecker considered misspelled, and adjusting the custom
dictionary as appropriate.  Some other stuff was noticed along the way
(loose->lose), so grep was used to look for other instances.

I did feel foolish renaming bike-shed-colours to bike-shed-colors, though.

Thanks all for the review.  Will remove the zombie stuff.

[dsymonds, 2011-05-18 01:32:30]

FYI

http://codereview.appspot.com/4536063/diff/4001/src/pkg/expvar/expvar_test.go
File src/pkg/expvar/expvar_test.go (left):

http://codereview.appspot.com/4536063/diff/4001/src/pkg/expvar/expvar_test.go...
src/pkg/expvar/expvar_test.go:79: colours := NewMap("bike-shed-colours")
I am sorely tempted to bikeshed about the s/colours/colors/.  ;-)

[adg, 2011-05-18 01:34:42]

On 18 May 2011 11:27,  <robert.hencke@gmail.com> wrote:
> I used grep, the Mac OS X spellchecker, and elbow grease.

I, for one, really value this kind of work. Thanks for the effort.

Andrew

[rh, 2011-05-18 01:38:54]

Hello ality@pbrane.org, bradfitz@golang.org, rsc@golang.org,
dsymonds@golang.org, adg@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[zhai, 2011-05-18 01:40:00]

and run

gofmt -r 'a[b:len(a)] -> a[b:]'  -w $GOROOT/src/pkg
gofmt -r 'a[0:b] -> a[:b]'  -w $GOROOT/src/pkg

[dsymonds, 2011-05-18 01:45:20]

On Wed, May 18, 2011 at 11:40 AM, zhai <qyzhai@gmail.com> wrote:

> and run
> gofmt -r 'a[b:len(a)] -> a[b:]'  -w $GOROOT/src/pkg
> gofmt -r 'a[0:b] -> a[:b]'  -w $GOROOT/src/pkg

Please don't. That would be worthy of its own CL.

[rh, 2011-05-18 01:46:35]

Thank you adg, everyone.

Will try to get I-Z done next week.

[dchest, 2011-05-18 10:33:27]

http://codereview.appspot.com/4536063/diff/2059/src/pkg/container/heap/heap.go
File src/pkg/container/heap/heap.go (right):

http://codereview.appspot.com/4536063/diff/2059/src/pkg/container/heap/heap.g...
src/pkg/container/heap/heap.go:25: // A heap must be initialized before any of
the heap operations
Shouldn't this still be "heaper", as in "Writer", "Closer", etc?

[ality, 2011-05-18 12:40:47]

dchest@gmail.com once said:
>
http://codereview.appspot.com/4536063/diff/2059/src/pkg/container/heap/heap.g...
> src/pkg/container/heap/heap.go:25: // A heap must be initialized before
> any of the heap operations
> Shouldn't this still be "heaper", as in "Writer", "Closer", etc?

No. It's just a typo.

[rsc, 2011-05-18 17:15:00]

*** Submitted as http://code.google.com/p/go/source/detail?r=3d83d1c93822 ***

pkg: spelling tweaks, A-H

R=ality, bradfitz, rsc, dsymonds, adg, qyzhai, dchest
CC=golang-dev
http://codereview.appspot.com/4536063

Committer: Russ Cox <rsc@golang.org>