code review 9149045: cmd/api: add more platforms

cmd/api: add more platforms
as OpenBSD lacks 4 errno constants, api/go1.txt is updated so that
api check won't fail.

[minux1, 2013-05-03 09:07:48]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[minux1, 2013-05-03 09:30:07]

PTAL. Removed openbsd/arm.

[minux1, 2013-05-03 10:09:17]

Openbsd port lacks these in its syscall package:
-pkg syscall, const EBADMSG Errno
-pkg syscall, const EMULTIHOP Errno
-pkg syscall, const ENOLINK Errno
-pkg syscall, const EPROTO Errno

should we fix them or just drop openbsd from the list?

[iant, 2013-05-03 13:26:45]

On Fri, May 3, 2013 at 3:09 AM,  <minux.ma@gmail.com> wrote:
> Openbsd port lacks these in its syscall package:
> -pkg syscall, const EBADMSG Errno
> -pkg syscall, const EMULTIHOP Errno
> -pkg syscall, const ENOLINK Errno
> -pkg syscall, const EPROTO Errno
>
> should we fix them or just drop openbsd from the list?

I took a look at an OpenBSD errno.h file and it didn't define any of
them.  Unless they have been added in a more recent version we
shouldn't define them for OpenBSD.

Ian

[minux1, 2013-05-03 21:50:11]

On Fri, May 3, 2013 at 9:26 PM, Ian Lance Taylor <iant@golang.org> wrote:

> On Fri, May 3, 2013 at 3:09 AM,  <minux.ma@gmail.com> wrote:
> > Openbsd port lacks these in its syscall package:
> > -pkg syscall, const EBADMSG Errno
> > -pkg syscall, const EMULTIHOP Errno
> > -pkg syscall, const ENOLINK Errno
> > -pkg syscall, const EPROTO Errno
> >
> > should we fix them or just drop openbsd from the list?
>
> I took a look at an OpenBSD errno.h file and it didn't define any of
> them.  Unless they have been added in a more recent version we
> shouldn't define them for OpenBSD.
>
Ah, thank you, I forgot to search for them first.

PTAL (nothing changed).
I just wanted to know how do I suppose to handle those 4 lines? add them
to except.txt? or modify go1.txt?

[minux1, 2013-05-05 22:46:59]

gentle ping.

[bradfitz, 2013-05-06 17:11:16]

LGTM

This will probably make "go tool api" slower, but that's not your problem.
We (I) can fix that later.


On Sun, May 5, 2013 at 3:46 PM, <minux.ma@gmail.com> wrote:

> gentle ping.
>
>
https://codereview.appspot.**com/9149045/<https://codereview.appspot.com/9149...
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[minux1, 2013-05-06 21:49:54]

Hi Brad, if I submit this, the 4 "missing" constants on openbsd will cause
the build to fail.

i can either change except.txt or go1.txt, which one do you prefer?

[r, 2013-05-06 22:08:14]

Don't check it in yet. It can wait. This tool is for us, not for the
people who will download Go 1.1 binaries.

-rob

[minux1, 2013-05-06 22:35:17]

On Tue, May 7, 2013 at 6:07 AM, Rob Pike <r@golang.org> wrote:

> Don't check it in yet. It can wait. This tool is for us, not for the
> people who will download Go 1.1 binaries.
>
Sure. My intention is to avoid later regrets like this:
http://codereview.appspot.com/6275050

now that i've run all.bash with this change, i'm sure we don't have any
incompatibilities in API between different platforms in the tree now.

[r, 2013-05-06 22:37:12]

thanks. if you've run it and it's clean, i'm comfortable waiting.

-rob


On Mon, May 6, 2013 at 3:34 PM, minux <minux.ma@gmail.com> wrote:
>
> On Tue, May 7, 2013 at 6:07 AM, Rob Pike <r@golang.org> wrote:
>>
>> Don't check it in yet. It can wait. This tool is for us, not for the
>> people who will download Go 1.1 binaries.
>
> Sure. My intention is to avoid later regrets like this:
> http://codereview.appspot.com/6275050
>
> now that i've run all.bash with this change, i'm sure we don't have any
> incompatibilities in API between different platforms in the tree now.

[bradfitz, 2013-05-20 21:24:35]

reverse ping.

[minux1, 2013-05-20 21:41:31]

Hi Brad, if I submit this, the 4 "missing" constants on openbsd will cause
the build to fail.

i can either change except.txt or go1*.txt, which one do you prefer?
alternatively, we can enhance cmd/api to note what platform does
the api file check.

[bradfitz, 2013-05-20 22:50:47]

It's fine to change go1.txt for this to explicitly spell out the contexts
for which it's supported:

+pkg syscall (darwin-386), const EBADMSG Errno
+pkg syscall (darwin-386-cgo), const EBADMSG Errno
+pkg syscall (darwin-amd64), const EBADMSG Errno
+pkg syscall (freebsd-386), const EBADMSG Errno
+pkg syscall (freebsd-amd64), const EBADMSG Errno
+pkg syscall (freebsd-arm), const EBADMSG Errno
+pkg syscall (linux-386), const EBADMSG Errno
+pkg syscall (linux-386-cgo), const EBADMSG Errno
+pkg syscall (linux-amd64), const EBADMSG Errno
+pkg syscall (linux-amd64-cgo), const EBADMSG Errno
+pkg syscall (linux-arm), const EBADMSG Errno
+pkg syscall (windows-386), const EBADMSG Errno
+pkg syscall (windows-amd64), const EBADMSG Errno

Or whatever it was in Go 1, for each of the constants.

And remove the 4 lines:

-pkg syscall, const EBADMSG Errno
-pkg syscall, const EMULTIHOP Errno
-pkg syscall, const ENOLINK Errno
-pkg syscall, const EPROTO Errno



On Mon, May 20, 2013 at 2:41 PM, <minux.ma@gmail.com> wrote:

> Hi Brad, if I submit this, the 4 "missing" constants on openbsd will
> cause
> the build to fail.
>
> i can either change except.txt or go1*.txt, which one do you prefer?
> alternatively, we can enhance cmd/api to note what platform does
> the api file check.
>
>
https://codereview.appspot.**com/9149045/<https://codereview.appspot.com/9149...
>

[minux1, 2013-05-21 13:47:49]

*** Submitted as https://code.google.com/p/go/source/detail?r=b373a884c5fd ***

cmd/api: add more platforms
as OpenBSD lacks 4 errno constants, api/go1.txt is updated so that
api check won't fail.

R=golang-dev, iant, bradfitz, r
CC=golang-dev
https://codereview.appspot.com/9149045