code review 6275050: api: add Linux/ARM to go1 API

api: add Linux/ARM to go1 API
It's very unfortunate that the type of Data field of struct
RawSockaddr is [14]uint8 on Linux/ARM instead of [14]int8
on all the others.
btw, it should be [14]int8 according to my header files.

[minux1, 2012-06-03 17:24:10]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[minux1, 2012-06-03 17:37:36]

I wonder why we don't check for freebsd-{386,amd64}-cgo?

[bradfitz, 2012-06-03 18:26:17]

I don't think it's worth the cost.  My gut feeling is that it wouldn't
catch any regressions that the rest of the existing contexts wouldn't
already.

I'm going to make the api tool faster, then maybe we can add more just for
completeness.

On Sun, Jun 3, 2012 at 10:37 AM, <minux.ma@gmail.com> wrote:

> I wonder why we don't check for freebsd-{386,amd64}-cgo?
>
>
http://codereview.appspot.com/**6275050/<http://codereview.appspot.com/6275050/>
>

[bradfitz, 2012-06-03 19:31:05]

LGTM

On Sun, Jun 3, 2012 at 10:24 AM, <minux.ma@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> api: add Linux/ARM to go1 API
> It's very unfortunate that the type of Data field of struct
> RawSockaddr is [14]uint8 on Linux/ARM instead of [14]int8
> on the others.
> btw, it should be [14]int8 according to my header files.
>
> Please review this at
http://codereview.appspot.com/**6275050/<http://codereview.appspot.com/6275050/>
>
> Affected files:
>  M api/go1.txt
>  M src/cmd/api/goapi.go
>
>
>

[minux1, 2012-06-04 07:22:22]

*** Submitted as http://code.google.com/p/go/source/detail?r=5538444d6f32 ***

api: add Linux/ARM to go1 API
It's very unfortunate that the type of Data field of struct
RawSockaddr is [14]uint8 on Linux/ARM instead of [14]int8
on all the others.
btw, it should be [14]int8 according to my header files.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6275050