Issue 9131043: Fixes bad strings in the filters

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9131043: Fixes bad strings in the filters

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by j.c.sackett

Modified:
11 years ago

Reviewers:
rharding, jeff.pihach, mp+162200

Visibility:
Public.

Description

Fixes bad strings in the filters The filter model refers to "category" when it should use "categories". It also mislabels several categories (e.g. "miscellaneous" instead of "misc"). This rememedies those problems. https://code.launchpad.net/~jcsackett/juju-gui/filter-strings-are-wrong/+merge/162200 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixes bad strings in the filters #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -23 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/models/browser.js	View	1	4 chunks	+42 lines, -7 lines	0 comments	Download
M	app/templates/filters.handlebars	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	app/widgets/filter.js	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	test/test_browser_models.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/test_filter_widget.js	View		3 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

jeff.pihach

LGTM with a small documentation request. https://codereview.appspot.com/9131043/diff/1/app/models/browser.js File app/models/browser.js (right): https://codereview.appspot.com/9131043/diff/1/app/models/browser.js#newcode176 app/models/browser.js:176: categories: { Any ...

11 years ago (2013-05-02 18:55:32 UTC) #3

j.c.sackett

On 2013/05/02 18:55:32, jeff.pihach wrote: > LGTM with a small documentation request. > > https://codereview.appspot.com/9131043/diff/1/app/models/browser.js ...

11 years ago (2013-05-02 19:08:20 UTC) #4

j.c.sackett

11 years ago (2013-05-02 19:12:21 UTC) #5

*** Submitted:

Fixes bad strings in the filters

The filter model refers to "category" when it should use "categories". It also
mislabels several categories (e.g. "miscellaneous" instead of "misc"). This
rememedies those problems.

R=rharding, jeff.pihach
CC=
https://codereview.appspot.com/9131043

Expand All Messages | Collapse All Messages