Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2469)

Issue 9131043: Fixes bad strings in the filters

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 12 months ago by j.c.sackett
Modified:
10 years, 12 months ago
Reviewers:
rharding, jeff.pihach, mp+162200
Visibility:
Public.

Description

Fixes bad strings in the filters The filter model refers to "category" when it should use "categories". It also mislabels several categories (e.g. "miscellaneous" instead of "misc"). This rememedies those problems. https://code.launchpad.net/~jcsackett/juju-gui/filter-strings-are-wrong/+merge/162200 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixes bad strings in the filters #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -23 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/models/browser.js View 1 4 chunks +42 lines, -7 lines 0 comments Download
M app/templates/filters.handlebars View 1 chunk +3 lines, -3 lines 0 comments Download
M app/widgets/filter.js View 2 chunks +4 lines, -4 lines 0 comments Download
M test/test_browser_models.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/test_filter_widget.js View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5
j.c.sackett
Please take a look.
10 years, 12 months ago (2013-05-02 18:14:10 UTC) #1
rharding
LGTM
10 years, 12 months ago (2013-05-02 18:46:17 UTC) #2
jeff.pihach
LGTM with a small documentation request. https://codereview.appspot.com/9131043/diff/1/app/models/browser.js File app/models/browser.js (right): https://codereview.appspot.com/9131043/diff/1/app/models/browser.js#newcode176 app/models/browser.js:176: categories: { Any ...
10 years, 12 months ago (2013-05-02 18:55:32 UTC) #3
j.c.sackett
On 2013/05/02 18:55:32, jeff.pihach wrote: > LGTM with a small documentation request. > > https://codereview.appspot.com/9131043/diff/1/app/models/browser.js ...
10 years, 12 months ago (2013-05-02 19:08:20 UTC) #4
j.c.sackett
10 years, 12 months ago (2013-05-02 19:12:21 UTC) #5
*** Submitted:

Fixes bad strings in the filters

The filter model refers to "category" when it should use "categories". It also
mislabels several categories (e.g. "miscellaneous" instead of "misc"). This
rememedies those problems.

R=rharding, jeff.pihach
CC=
https://codereview.appspot.com/9131043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b