Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(701)

Issue 90220043: Use trusty as default target series.

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 5 months ago by frankban
Modified:
5 years, 5 months ago
Reviewers:
rharding, mp+216695
Visibility:
Public.

Description

Use trusty as default target series. Switched to lp:~juju-gui/charms/trusty/juju-gui/trunk (I'll send an email after this branch is landed). Change "make deploy" to install the trusty charm by default. Also run "apt-get update" at the beginning of the install hook. Tests: `make unittest`. https://code.launchpad.net/~frankban/charms/precise/juju-gui/trusty-defaults/+merge/216695 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use trusty as default target series. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -26 lines) Patch
M .lbox View 1 chunk +1 line, -1 line 0 comments Download
M HACKING.md View 4 chunks +16 lines, -5 lines 0 comments Download
M Makefile View 1 chunk +2 lines, -1 line 0 comments Download
M README.md View 1 chunk +1 line, -1 line 0 comments Download
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M hooks/install View 1 chunk +6 lines, -2 lines 0 comments Download
M revision View 1 chunk +1 line, -1 line 0 comments Download
M tests/deploy.py View 3 chunks +6 lines, -5 lines 0 comments Download
M tests/example.py View 3 chunks +5 lines, -6 lines 0 comments Download
M tests/test_deploy.py View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6
frankban
Please take a look.
5 years, 5 months ago (2014-04-22 10:44:42 UTC) #1
rharding
Code looks good. Will qa. https://codereview.appspot.com/90220043/diff/1/HACKING.md File HACKING.md (right): https://codereview.appspot.com/90220043/diff/1/HACKING.md#newcode175 HACKING.md:175: we need to update ...
5 years, 5 months ago (2014-04-22 12:33:29 UTC) #2
rharding
Code looks good. Will qa.
5 years, 5 months ago (2014-04-22 12:35:12 UTC) #3
rharding
Code looks good. Will qa.
5 years, 5 months ago (2014-04-22 12:35:12 UTC) #4
rharding
On 2014/04/22 12:35:12, rharding wrote: > Code looks good. Will qa. LGTM
5 years, 5 months ago (2014-04-22 12:54:59 UTC) #5
frankban
5 years, 5 months ago (2014-04-22 12:58:42 UTC) #6
*** Submitted:

Use trusty as default target series.

Switched to lp:~juju-gui/charms/trusty/juju-gui/trunk
(I'll send an email after this branch is landed).

Change "make deploy" to install the trusty charm by default.

Also run "apt-get update" at the beginning of the install hook.

Tests: `make unittest`.

R=rharding
CC=
https://codereview.appspot.com/90220043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b