Issue 90220043: Use trusty as default target series.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 90220043: Use trusty as default target series.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by frankban

Modified:
10 years ago

Reviewers:
rharding, mp+216695

Visibility:
Public.

Description

Use trusty as default target series. Switched to lp:~juju-gui/charms/trusty/juju-gui/trunk (I'll send an email after this branch is landed). Change "make deploy" to install the trusty charm by default. Also run "apt-get update" at the beginning of the install hook. Tests: `make unittest`. https://code.launchpad.net/~frankban/charms/precise/juju-gui/trusty-defaults/+merge/216695 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use trusty as default target series. #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -26 lines)			Patch
M	.lbox	View	1 chunk	+1 line, -1 line	0 comments	Download
M	HACKING.md	View	4 chunks	+16 lines, -5 lines	0 comments	Download
M	Makefile	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	README.md	View	1 chunk	+1 line, -1 line	0 comments	Download
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	hooks/install	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	revision	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/deploy.py	View	3 chunks	+6 lines, -5 lines	0 comments	Download
M	tests/example.py	View	3 chunks	+5 lines, -6 lines	0 comments	Download
M	tests/test_deploy.py	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rharding

Code looks good. Will qa. https://codereview.appspot.com/90220043/diff/1/HACKING.md File HACKING.md (right): https://codereview.appspot.com/90220043/diff/1/HACKING.md#newcode175 HACKING.md:175: we need to update ...

10 years ago (2014-04-22 12:33:29 UTC) #2

rharding

On 2014/04/22 12:35:12, rharding wrote: > Code looks good. Will qa. LGTM

10 years ago (2014-04-22 12:54:59 UTC) #5

frankban

10 years ago (2014-04-22 12:58:42 UTC) #6

*** Submitted:

Use trusty as default target series.

Switched to lp:~juju-gui/charms/trusty/juju-gui/trunk
(I'll send an email after this branch is landed).

Change "make deploy" to install the trusty charm by default.

Also run "apt-get update" at the beginning of the install hook.

Tests: `make unittest`.

R=rharding
CC=
https://codereview.appspot.com/90220043

Expand All Messages | Collapse All Messages