Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1213)

Issue 9015043: jujuc: fix lp:1172895

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by fwereade
Modified:
9 years, 7 months ago
Reviewers:
mp+161445, dimitern, rog
Visibility:
Public.

Description

jujuc: fix lp:1172895 I have no idea how we ended up changing the implementation here. https://code.launchpad.net/~fwereade/juju-core/fix-relation-list-args/+merge/161445 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : jujuc: fix lp:1172895 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -26 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M worker/uniter/jujuc/relation-get.go View 1 chunk +0 lines, -1 line 0 comments Download
M worker/uniter/jujuc/relation-list.go View 2 chunks +4 lines, -13 lines 0 comments Download
M worker/uniter/jujuc/relation-list_test.go View 4 chunks +14 lines, -12 lines 0 comments Download

Messages

Total messages: 5
fwereade
Please take a look.
9 years, 7 months ago (2013-04-29 15:36:50 UTC) #1
fwereade
https://codereview.appspot.com/9015043/diff/1/worker/uniter/jujuc/relation-get.go File worker/uniter/jujuc/relation-get.go (left): https://codereview.appspot.com/9015043/diff/1/worker/uniter/jujuc/relation-get.go#oldcode42 worker/uniter/jujuc/relation-get.go:42: // TODO FWER implement --format shell lp:1033511 note: we ...
9 years, 7 months ago (2013-04-29 16:37:13 UTC) #2
dimitern
LGTM
9 years, 7 months ago (2013-04-29 16:56:09 UTC) #3
rog
LGTM assuming this is the python behaviour
9 years, 7 months ago (2013-04-30 14:35:44 UTC) #4
fwereade
9 years, 7 months ago (2013-05-02 16:02:04 UTC) #5
*** Submitted:

jujuc: fix lp:1172895

I have no idea how we ended up changing the implementation here.

R=
CC=
https://codereview.appspot.com/9015043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b