Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(31)

Issue 90110043: code review 90110043: strings: fix off-by-one error in test (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by ruiu
Modified:
7 years, 7 months ago
Reviewers:
iant
CC:
golang-codereviews, iant
Visibility:
Public.

Description

strings: fix off-by-one error in test Previously it would panic because of out-of-bound access if s1 is longer than s2.

Patch Set 1 #

Patch Set 2 : diff -r c313673339c4 https://code.google.com/p/go #

Patch Set 3 : diff -r c313673339c4 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/strings/strings_test.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
ruiu
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
7 years, 7 months ago (2014-04-21 23:46:09 UTC) #1
iant
LGTM
7 years, 7 months ago (2014-04-21 23:59:57 UTC) #2
iant
7 years, 7 months ago (2014-04-22 00:00:32 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=f8b50ad4cac4 ***

strings: fix off-by-one error in test

Previously it would panic because of out-of-bound access
if s1 is longer than s2.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/90110043

Committer: Ian Lance Taylor <iant@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b