Issue 90110043: code review 90110043: strings: fix off-by-one error in test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 90110043: code review 90110043: strings: fix off-by-one error in test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 12 months ago by ruiu

Modified:
9 years, 12 months ago

Reviewers:
iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

strings: fix off-by-one error in test Previously it would panic because of out-of-bound access if s1 is longer than s2.

Patch Set 1 #

Patch Set 2 : diff -r c313673339c4 https://code.google.com/p/go #

Patch Set 3 : diff -r c313673339c4 https://code.google.com/p/go #

Created: 9 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/strings/strings_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ruiu

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

9 years, 12 months ago (2014-04-21 23:46:09 UTC) #1

iant

9 years, 12 months ago (2014-04-22 00:00:32 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=f8b50ad4cac4 ***

strings: fix off-by-one error in test

Previously it would panic because of out-of-bound access
if s1 is longer than s2.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/90110043

Committer: Ian Lance Taylor <iant@golang.org>

Expand All Messages | Collapse All Messages