Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2271)

Issue 8872044: Fix resize events for charm panel

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by matthew.scott
Modified:
9 years, 7 months ago
Reviewers:
bac, mp+159868, benji
Visibility:
Public.

Description

Fix resize events for charm panel Some resize events weren't being caught by the charm panel because they were being fired on the topology, rather than globally. https://code.launchpad.net/~makyo/juju-gui/resize-breaks-panel/+merge/159868 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix resize events for charm panel #

Patch Set 3 : Fix resize events for charm panel #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/charm-panel.js View 1 chunk +0 lines, -7 lines 0 comments Download
M app/views/topology/viewport.js View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/views/stylesheet.less View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/test_environment_view.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/test_viewport_module.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5
matthew.scott
Please take a look.
9 years, 7 months ago (2013-04-19 18:33:46 UTC) #1
matthew.scott
Please take a look.
9 years, 7 months ago (2013-04-19 19:21:46 UTC) #2
benji
LGTM
9 years, 7 months ago (2013-04-19 19:27:54 UTC) #3
bac
LGTM and QA'd
9 years, 7 months ago (2013-04-19 20:08:59 UTC) #4
matthew.scott
9 years, 7 months ago (2013-04-19 20:16:48 UTC) #5
*** Submitted:

Fix resize events for charm panel

Some resize events weren't being caught by the charm panel because they were
being fired on the topology, rather than globally.

R=benji, bac
CC=
https://codereview.appspot.com/8872044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b