Issue 8872044: Fix resize events for charm panel

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8872044: Fix resize events for charm panel

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by matthew.scott

Modified:
11 years, 7 months ago

Reviewers:
bac, mp+159868, benji

Visibility:
Public.

Description

Fix resize events for charm panel Some resize events weren't being caught by the charm panel because they were being fired on the topology, rather than globally. https://code.launchpad.net/~makyo/juju-gui/resize-breaks-panel/+merge/159868 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix resize events for charm panel #

Patch Set 3 : Fix resize events for charm panel #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -12 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/views/charm-panel.js	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	app/views/topology/viewport.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/views/stylesheet.less	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	test/test_environment_view.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/test_viewport_module.js	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

matthew.scott

11 years, 7 months ago (2013-04-19 20:16:48 UTC) #5

*** Submitted:

Fix resize events for charm panel

Some resize events weren't being caught by the charm panel because they were
being fired on the topology, rather than globally.

R=benji, bac
CC=
https://codereview.appspot.com/8872044

Expand All Messages | Collapse All Messages