Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1970)

Issue 8812043: gallimaufry

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by gary.poster
Modified:
9 years, 7 months ago
Reviewers:
mp+159271, jeff.pihach, matthew.scott
Visibility:
Public.

Description

gallimaufry Title is in homage to benji's potpourri. - Fix 1169350: sandbox was not marking subordinate charms correctly. - Fix 1169668: subordinate relations were not shown because of the id change. - Simplify test charm store code. https://code.launchpad.net/~gary/juju-gui/bug1169350/+merge/159271 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : gallimaufry #

Patch Set 3 : gallimaufry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -63 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/store/env/fakebackend.js View 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/topology/relation.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_app.js View 2 chunks +1 line, -2 lines 0 comments Download
M test/test_fakebackend.js View 11 chunks +18 lines, -20 lines 0 comments Download
M test/test_sandbox.js View 1 chunk +1 line, -1 line 0 comments Download
M test/utils.js View 1 chunk +30 lines, -39 lines 0 comments Download

Messages

Total messages: 4
gary.poster
Please take a look.
9 years, 7 months ago (2013-04-17 01:12:42 UTC) #1
matthew.scott
LGTM - thanks for the fixes and the test util.
9 years, 7 months ago (2013-04-17 01:15:41 UTC) #2
jeff.pihach
LGTM nice improvements! https://codereview.appspot.com/8812043/diff/1/app/store/env/fakebackend.js File app/store/env/fakebackend.js (right): https://codereview.appspot.com/8812043/diff/1/app/store/env/fakebackend.js#newcode344 app/store/env/fakebackend.js:344: data.is_subordinate = data.subordinate; Ahh it was ...
9 years, 7 months ago (2013-04-17 01:18:49 UTC) #3
gary.poster
9 years, 7 months ago (2013-04-17 01:30:30 UTC) #4
*** Submitted:

gallimaufry

Title is in homage to benji's potpourri.

- Fix 1169350: sandbox was not marking subordinate charms correctly.
- Fix 1169668: subordinate relations were not shown because of the id change.
- Simplify test charm store code.

R=matthew.scott, jeff.pihach
CC=
https://codereview.appspot.com/8812043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b