Issue 8812043: gallimaufry

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8812043: gallimaufry

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by gary.poster

Modified:
11 years ago

Reviewers:
mp+159271, jeff.pihach, matthew.scott

Visibility:
Public.

Description

gallimaufry Title is in homage to benji's potpourri. - Fix 1169350: sandbox was not marking subordinate charms correctly. - Fix 1169668: subordinate relations were not shown because of the id change. - Simplify test charm store code. https://code.launchpad.net/~gary/juju-gui/bug1169350/+merge/159271 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : gallimaufry #

Patch Set 3 : gallimaufry #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -63 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/store/env/fakebackend.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/views/topology/relation.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/test_app.js	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	test/test_fakebackend.js	View		11 chunks	+18 lines, -20 lines	0 comments	Download
M	test/test_sandbox.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/utils.js	View		1 chunk	+30 lines, -39 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jeff.pihach

LGTM nice improvements! https://codereview.appspot.com/8812043/diff/1/app/store/env/fakebackend.js File app/store/env/fakebackend.js (right): https://codereview.appspot.com/8812043/diff/1/app/store/env/fakebackend.js#newcode344 app/store/env/fakebackend.js:344: data.is_subordinate = data.subordinate; Ahh it was ...

11 years ago (2013-04-17 01:18:49 UTC) #3

gary.poster

11 years ago (2013-04-17 01:30:30 UTC) #4

*** Submitted:

gallimaufry

Title is in homage to benji's potpourri.

- Fix 1169350: sandbox was not marking subordinate charms correctly.
- Fix 1169668: subordinate relations were not shown because of the id change.
- Simplify test charm store code.

R=matthew.scott, jeff.pihach
CC=
https://codereview.appspot.com/8812043

Expand All Messages | Collapse All Messages