Code review - Issue 8812043: gallimaufryhttps://codereview.appspot.com/2013-04-17T01:30:30+00:00rietveld
Message from unknown
2013-04-17T01:12:37+00:00gary.posterurn:md5:82fdc7b536e1f891be88a3e81fc63de9
Message from gary.poster@canonical.com
2013-04-17T01:12:42+00:00gary.posterurn:md5:1b3718371e5b86bb35a2a1a0105071ca
Please take a look.
Message from matthew.scott@canonical.com
2013-04-17T01:15:41+00:00matthew.scotturn:md5:bf7d7329a6966d9471923e7235e1e0c9
LGTM - thanks for the fixes and the test util.
Message from jeff.pihach@canonical.com
2013-04-17T01:18:49+00:00jeff.pihachurn:md5:c91ffdc5f85050db9bfeab4bdbb18eb0
LGTM nice improvements!
https://codereview.appspot.com/8812043/diff/1/app/store/env/fakebackend.js
File app/store/env/fakebackend.js (right):
https://codereview.appspot.com/8812043/diff/1/app/store/env/fakebackend.js#newcode344
app/store/env/fakebackend.js:344: data.is_subordinate = data.subordinate;
Ahh it was a naming mixup.
https://codereview.appspot.com/8812043/diff/1/test/utils.js
File test/utils.js (right):
https://codereview.appspot.com/8812043/diff/1/test/utils.js#newcode62
test/utils.js:62: _cached_charms: (function() {
Great idea
Message from unknown
2013-04-17T01:22:42+00:00gary.posterurn:md5:24b1d859d45edc071fca25cb1f92eb5d
Message from unknown
2013-04-17T01:27:23+00:00gary.posterurn:md5:ce2b06f1903672269cfa190d001cda41
Message from gary.poster@canonical.com
2013-04-17T01:30:30+00:00gary.posterurn:md5:657cb22a2103fec1233d9a7d7e875b7f
*** Submitted:
gallimaufry
Title is in homage to benji's potpourri.
- Fix 1169350: sandbox was not marking subordinate charms correctly.
- Fix 1169668: subordinate relations were not shown because of the id change.
- Simplify test charm store code.
R=matthew.scott, jeff.pihach
CC=
https://codereview.appspot.com/8812043