Trusty charm.

Trusty charm.

Make the charm work on trusty.
Also update the charm documentation.

QA:
Please run the unit and functional tests
using both precise and trusty.
Follow the instructions in the HACKING file.

https://code.launchpad.net/~frankban/charms/precise/juju-gui/trusty-charm/+merge/215867

(do not edit description out of merge proposal)

[frankban, 2014-04-15 13:06:27]

Please take a look.

[bac, 2014-04-15 13:50:15]

LGTM.
Will now QA.

https://codereview.appspot.com/88100044/diff/1/HACKING.md
File HACKING.md (left):

https://codereview.appspot.com/88100044/diff/1/HACKING.md#oldcode23
HACKING.md:23: do not yet have an environment defined, the Jitsu command
"setup-environment"
yay, death to jitsu

https://codereview.appspot.com/88100044/diff/1/HACKING.md
File HACKING.md (right):

https://codereview.appspot.com/88100044/diff/1/HACKING.md#newcode24
HACKING.md:24: way to get started. See
https://pypi.python.org/pypi/juju-quickstart.
Do you prefer pypi to the package just because we have tighter control over it
and it may be more up-to-date?

https://codereview.appspot.com/88100044/diff/1/HACKING.md#newcode62
HACKING.md:62: version the charm will be deployed by functional tests. For
instance, to test
This sentence ends clumsily.  How about

Since functional tests deploy the charm in the
bootstrap node, setting the default series also selects which series
version the charm will be deployed by functional tests.

https://codereview.appspot.com/88100044/diff/1/HACKING.md#newcode66
HACKING.md:66: Long story short, to run both unit and functional the tests:
s/the tests/tests/

https://codereview.appspot.com/88100044/diff/1/HACKING.md#newcode128
HACKING.md:128: The `make deploy` command also support specifying the OS version
used to deploy
s/support/supports/

https://codereview.appspot.com/88100044/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/88100044/diff/1/Makefile#newcode83
Makefile:83: @echo 'make deploy [JUJU_ENV="my-juju-env"] [SERIES="trusty"] -
Deploy and'
Shouldn't this say SERIES="precise|trusty" or do you just include trusty because
precise is the default?

https://codereview.appspot.com/88100044/diff/1/README.md
File README.md (right):

https://codereview.appspot.com/88100044/diff/1/README.md#newcode47
README.md:47: add additional machines (i.e. the GUI is installed in the
bootstrap node).
Two parenthetic i.e. clauses in one sentence is a red flag.  How about:

When possible, Quickstart conserves resources by installing the GUI on the
bootstrap node.  This colocation is not possible when using a local (LXC)
environment.

https://codereview.appspot.com/88100044/diff/1/README.md#newcode165
README.md:165: While the Juju GUI itself is a client side JavaScript
application, the charm
trivial: client-side

https://codereview.appspot.com/88100044/diff/1/README.md#newcode166
README.md:166: installation also involves configuring a starting a GUI server,
which is
configuring and starting?

https://codereview.appspot.com/88100044/diff/1/README.md#newcode205
README.md:205: * The legacy server is no longer supported/tested staring from
trusty.
typo:starting

[frankban, 2014-04-15 14:25:18]

Please take a look.

https://codereview.appspot.com/88100044/diff/1/HACKING.md
File HACKING.md (right):

https://codereview.appspot.com/88100044/diff/1/HACKING.md#newcode24
HACKING.md:24: way to get started. See
https://pypi.python.org/pypi/juju-quickstart.
On 2014/04/15 13:50:16, bac wrote:
> Do you prefer pypi to the package just because we have tighter control over it
> and it may be more up-to-date?

I prefer PyPI because the page automatically shows the most recent quickstart
README, including installation instructions.

https://codereview.appspot.com/88100044/diff/1/HACKING.md#newcode62
HACKING.md:62: version the charm will be deployed by functional tests. For
instance, to test
On 2014/04/15 13:50:16, bac wrote:
> This sentence ends clumsily.  How about
> 
> Since functional tests deploy the charm in the
> bootstrap node, setting the default series also selects which series
> version the charm will be deployed by functional tests.

Done.

https://codereview.appspot.com/88100044/diff/1/HACKING.md#newcode66
HACKING.md:66: Long story short, to run both unit and functional the tests:
On 2014/04/15 13:50:16, bac wrote:
> s/the tests/tests/

Done.

https://codereview.appspot.com/88100044/diff/1/HACKING.md#newcode128
HACKING.md:128: The `make deploy` command also support specifying the OS version
used to deploy
On 2014/04/15 13:50:16, bac wrote:
> s/support/supports/

Done.

https://codereview.appspot.com/88100044/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/88100044/diff/1/Makefile#newcode83
Makefile:83: @echo 'make deploy [JUJU_ENV="my-juju-env"] [SERIES="trusty"] -
Deploy and'
On 2014/04/15 13:50:16, bac wrote:
> Shouldn't this say SERIES="precise|trusty" or do you just include trusty
because
> precise is the default?

Yes, "trusty" is just an example, and "precise" is the default.

https://codereview.appspot.com/88100044/diff/1/README.md
File README.md (right):

https://codereview.appspot.com/88100044/diff/1/README.md#newcode47
README.md:47: add additional machines (i.e. the GUI is installed in the
bootstrap node).
On 2014/04/15 13:50:16, bac wrote:
> Two parenthetic i.e. clauses in one sentence is a red flag.  How about:
> 
> When possible, Quickstart conserves resources by installing the GUI on the
> bootstrap node.  This colocation is not possible when using a local (LXC)
> environment.

Done.

https://codereview.appspot.com/88100044/diff/1/README.md#newcode165
README.md:165: While the Juju GUI itself is a client side JavaScript
application, the charm
On 2014/04/15 13:50:16, bac wrote:
> trivial: client-side

Done.

https://codereview.appspot.com/88100044/diff/1/README.md#newcode166
README.md:166: installation also involves configuring a starting a GUI server,
which is
On 2014/04/15 13:50:16, bac wrote:
> configuring and starting?

Done.

https://codereview.appspot.com/88100044/diff/1/README.md#newcode205
README.md:205: * The legacy server is no longer supported/tested staring from
trusty.
On 2014/04/15 13:50:16, bac wrote:
> typo:starting

Done, also fixed in the config.yaml.

[bac, 2014-04-15 16:13:27]

QA OK

[frankban, 2014-04-15 16:20:32]

*** Submitted:

Trusty charm.

Make the charm work on trusty.
Also update the charm documentation.

QA:
Please run the unit and functional tests
using both precise and trusty.
Follow the instructions in the HACKING file.

R=bac
CC=
https://codereview.appspot.com/88100044