Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(186)

Issue 88100044: Trusty charm.

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by frankban
Modified:
8 years, 7 months ago
Reviewers:
bac, mp+215867
Visibility:
Public.

Description

Trusty charm. Make the charm work on trusty. Also update the charm documentation. QA: Please run the unit and functional tests using both precise and trusty. Follow the instructions in the HACKING file. https://code.launchpad.net/~frankban/charms/precise/juju-gui/trusty-charm/+merge/215867 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 19

Patch Set 2 : Trusty charm. #

Patch Set 3 : Trusty charm. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -94 lines) Patch
M HACKING.md View 1 6 chunks +30 lines, -30 lines 0 comments Download
M Makefile View 1 chunk +7 lines, -6 lines 0 comments Download
M README.md View 1 5 chunks +87 lines, -26 lines 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M config.yaml View 1 1 chunk +4 lines, -1 line 0 comments Download
M hooks/utils.py View 1 chunk +6 lines, -9 lines 0 comments Download
M revision View 1 chunk +1 line, -1 line 0 comments Download
M tests/20-functional.test View 6 chunks +15 lines, -20 lines 0 comments Download
M tests/deploy.py View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5
frankban
Please take a look.
8 years, 7 months ago (2014-04-15 13:06:27 UTC) #1
bac
LGTM. Will now QA. https://codereview.appspot.com/88100044/diff/1/HACKING.md File HACKING.md (left): https://codereview.appspot.com/88100044/diff/1/HACKING.md#oldcode23 HACKING.md:23: do not yet have an ...
8 years, 7 months ago (2014-04-15 13:50:15 UTC) #2
frankban
Please take a look. https://codereview.appspot.com/88100044/diff/1/HACKING.md File HACKING.md (right): https://codereview.appspot.com/88100044/diff/1/HACKING.md#newcode24 HACKING.md:24: way to get started. See ...
8 years, 7 months ago (2014-04-15 14:25:18 UTC) #3
bac
QA OK
8 years, 7 months ago (2014-04-15 16:13:27 UTC) #4
frankban
8 years, 7 months ago (2014-04-15 16:20:32 UTC) #5
*** Submitted:

Trusty charm.

Make the charm work on trusty.
Also update the charm documentation.

QA:
Please run the unit and functional tests
using both precise and trusty.
Follow the instructions in the HACKING file.

R=bac
CC=
https://codereview.appspot.com/88100044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b