Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1668)

Issue 8797046: upstart: add support for the limit verb (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by dfc
Modified:
9 years, 7 months ago
Reviewers:
mp+161275
Visibility:
Public.

Description

upstart: add support for the limit verb Add support for limit <noun> <value> <value> to upstart. This is required for increasing the connection limit for mongodb. https://code.launchpad.net/~dave-cheney/juju-core/120-upstart-add-limit-verb/+merge/161275 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : upstart: add support for the limit verb #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M upstart/upstart.go View 2 chunks +4 lines, -0 lines 0 comments Download
M upstart/upstart_test.go View 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 6
dfc
Please take a look.
9 years, 7 months ago (2013-04-27 04:32:12 UTC) #1
dfc
On 2013/04/27 04:32:12, dfc wrote: > Please take a look. ping
9 years, 7 months ago (2013-04-29 05:14:24 UTC) #2
dimitern
LGTM
9 years, 7 months ago (2013-04-29 10:01:30 UTC) #3
rog
LGTM with one trivial remark https://codereview.appspot.com/8797046/diff/1/upstart/upstart.go File upstart/upstart.go (right): https://codereview.appspot.com/8797046/diff/1/upstart/upstart.go#newcode99 upstart/upstart.go:99: {{range $k, $v := ...
9 years, 7 months ago (2013-04-29 10:04:15 UTC) #4
dfc
https://codereview.appspot.com/8797046/diff/1/upstart/upstart.go File upstart/upstart.go (right): https://codereview.appspot.com/8797046/diff/1/upstart/upstart.go#newcode99 upstart/upstart.go:99: {{range $k, $v := .Limit}}limit {{$k}} {{$v|printf "%s"}} On ...
9 years, 7 months ago (2013-04-29 10:05:38 UTC) #5
dfc
9 years, 7 months ago (2013-04-30 05:22:31 UTC) #6
*** Submitted:

upstart: add support for the limit verb

Add support for limit <noun> <value> <value> to upstart. This is required for
increasing the connection limit for mongodb.

R=dimitern, rog
CC=
https://codereview.appspot.com/8797046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b