upstart: add support for the limit verb

upstart: add support for the limit verb

Add support for limit <noun> <value> <value> to upstart. This is required for increasing the connection limit for mongodb.

https://code.launchpad.net/~dave-cheney/juju-core/120-upstart-add-limit-verb/+merge/161275

(do not edit description out of merge proposal)

[dave_cheney.net, 2013-04-27 04:32:12]

Please take a look.

[dave_cheney.net, 2013-04-29 05:14:24]

On 2013/04/27 04:32:12, dfc wrote:
> Please take a look.

ping

[dimitern, 2013-04-29 10:01:30]

LGTM

[rog, 2013-04-29 10:04:15]

LGTM with one trivial remark

https://codereview.appspot.com/8797046/diff/1/upstart/upstart.go
File upstart/upstart.go (right):

https://codereview.appspot.com/8797046/diff/1/upstart/upstart.go#newcode99
upstart/upstart.go:99: {{range $k, $v := .Limit}}limit {{$k}} {{$v|printf "%s"}}
s/{{$v|printf "%s"}}/{{$v}}

?

[dave_cheney.net, 2013-04-29 10:05:38]

https://codereview.appspot.com/8797046/diff/1/upstart/upstart.go
File upstart/upstart.go (right):

https://codereview.appspot.com/8797046/diff/1/upstart/upstart.go#newcode99
upstart/upstart.go:99: {{range $k, $v := .Limit}}limit {{$k}} {{$v|printf "%s"}}
On 2013/04/29 10:04:20, rog wrote:
> s/{{$v|printf "%s"}}/{{$v}}
> 
> ?

Thanks, I totally cargo culted that from the line above.

[dave_cheney.net, 2013-04-30 05:22:31]

*** Submitted:

upstart: add support for the limit verb

Add support for limit <noun> <value> <value> to upstart. This is required for
increasing the connection limit for mongodb.

R=dimitern, rog
CC=
https://codereview.appspot.com/8797046