Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(967)

Issue 8750047: TRIVIAL: Dragging ghost services leaves attrs.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by matthew.scott
Modified:
9 years, 7 months ago
Reviewers:
mp+160210, jeff.pihach, gary.poster
Visibility:
Public.

Description

TRIVIAL: Dragging ghost services leaves attrs. If you drag a ghost service and then deploy it, it leaves x and y attributes on the service, which are now removed, ensuring that dragging doesn't cause 'jumping'. A test was added for these attributes. https://code.launchpad.net/~makyo/juju-gui/ghost-drag-1169782/+merge/160210 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : TRIVIAL: Dragging ghost services leaves attrs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/charm-panel.js View 1 chunk +4 lines, -1 line 0 comments Download
M test/test_charm_panel.js View 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 4
matthew.scott
Please take a look.
9 years, 7 months ago (2013-04-22 21:12:03 UTC) #1
gary.poster
LGTM! Thanks!
9 years, 7 months ago (2013-04-22 21:13:34 UTC) #2
jeff.pihach
LGTM - let er rip!
9 years, 7 months ago (2013-04-22 21:17:23 UTC) #3
matthew.scott
9 years, 7 months ago (2013-04-22 21:22:45 UTC) #4
*** Submitted:

TRIVIAL: Dragging ghost services leaves attrs.

If you drag a ghost service and then deploy it, it leaves x and y attributes on
the service, which are now removed, ensuring that dragging doesn't cause
'jumping'.  A test was added for these attributes.

R=gary.poster, jeff.pihach
CC=
https://codereview.appspot.com/8750047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b