Issue 8750047: TRIVIAL: Dragging ghost services leaves attrs.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8750047: TRIVIAL: Dragging ghost services leaves attrs.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 12 months ago by matthew.scott

Modified:
10 years, 12 months ago

Reviewers:
mp+160210, jeff.pihach, gary.poster

Visibility:
Public.

Description

TRIVIAL: Dragging ghost services leaves attrs. If you drag a ghost service and then deploy it, it leaves x and y attributes on the service, which are now removed, ensuring that dragging doesn't cause 'jumping'. A test was added for these attributes. https://code.launchpad.net/~makyo/juju-gui/ghost-drag-1169782/+merge/160210 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : TRIVIAL: Dragging ghost services leaves attrs. #

Created: 10 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -4 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/views/charm-panel.js	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	test/test_charm_panel.js	View	2 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

matthew.scott

10 years, 12 months ago (2013-04-22 21:22:45 UTC) #4

*** Submitted:

TRIVIAL: Dragging ghost services leaves attrs.

If you drag a ghost service and then deploy it, it leaves x and y attributes on
the service, which are now removed, ensuring that dragging doesn't cause
'jumping'.  A test was added for these attributes.

R=gary.poster, jeff.pihach
CC=
https://codereview.appspot.com/8750047

Expand All Messages | Collapse All Messages