code review 8715043: cmd/ld: ignore PE sections that are not code or data

cmd/ld: ignore PE sections that are not code or data

Update issue 5106
Update issue 5273

[minux1, 2013-04-15 04:21:27]

Hi iant, this change is still needed for windows/amd64
to solve issue 5273.

LGTM.

[iant, 2013-04-15 05:33:28]

On Sun, Apr 14, 2013 at 9:21 PM,  <minux.ma@gmail.com> wrote:
> Hi iant, this change is still needed for windows/amd64
> to solve issue 5273.
>
> LGTM.
>
> https://codereview.appspot.com/8715043/

But according to the replies on issue 5273, it does not actually fix
the problem.  I would prefer to see a complete fix before submitting
this, since I'm not wholly convinced it is the right approach.

Ian

[iant, 2013-04-15 05:38:12]

On Sun, Apr 14, 2013 at 10:33 PM, Ian Lance Taylor <iant@golang.org> wrote:
>
> But according to the replies on issue 5273, it does not actually fix
> the problem.  I would prefer to see a complete fix before submitting
> this, since I'm not wholly convinced it is the right approach.

Oh, sorry, I forgot to refresh my open page for 5273.  I see that it
does work at least in some cases.

Ian

[iant, 2013-04-15 05:38:48]

Hello minux.ma@gmail.com, r (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[minux1, 2013-04-15 06:50:38]

LGTM. Leave for r.

I created https://codereview.appspot.com/8764043 to
test linking dynamic library on windows.

[r, 2013-04-15 17:12:14]

LGTM

[iant, 2013-04-15 17:36:10]

*** Submitted as https://code.google.com/p/go/source/detail?r=824737065aef ***

cmd/ld: ignore PE sections that are not code or data

Update issue 5106
Update issue 5273

R=minux.ma, r
CC=golang-dev
https://codereview.appspot.com/8715043