code review 8764043: misc/cgo/testso: enable test on windows

misc/cgo/testso: enable test on windows
Depends on CL 8715043 and CL 8676050.
Fixes issue 5273.

[minux1, 2013-04-15 07:00:53]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[gobot, 2013-04-15 20:42:21]

R=brainman (assigned by minux)

[brainman, 2013-04-16 00:04:25]

LGTM

as much as I know about it :-) Thank you.

Alex

https://codereview.appspot.com/8764043/diff/13001/misc/cgo/testso/test.bat
File misc/cgo/testso/test.bat (right):

https://codereview.appspot.com/8764043/diff/13001/misc/cgo/testso/test.bat#ne...
misc/cgo/testso/test.bat:13: del /F cgoso_c.o libcgosotest.dll main.exe 2>NUL
I would move that line to after :end label, so we do not leave tmp files around
in case of failure.

[minux1, 2013-04-19 15:39:57]

Hello alex.brainman@gmail.com (cc: gobot@golang.org,
golang-dev@googlegroups.com),

Please take another look.

[minux1, 2013-04-19 15:41:32]

This depends on CL 8715043 (already submitted) and CL 8676050
(a follow-up CL to the former).

[minux1, 2013-04-21 15:59:53]

ping?

this is fairly important for Go 1.1, as it both serves as
a regression test and an example for windows people
(we've seen many Go 1.1-incompatible cgo usages on
the issue tracker, we should provide an example)

[r, 2013-04-21 16:13:06]

LGTM

https://codereview.appspot.com/8764043/diff/19001/misc/cgo/testso/cgoso_c.c
File misc/cgo/testso/cgoso_c.c (right):

https://codereview.appspot.com/8764043/diff/19001/misc/cgo/testso/cgoso_c.c#n...
misc/cgo/testso/cgoso_c.c:10: // the main executable pass the function pointer
to us.
A Windows DLL is unable to call an arbitrary functions in the main executable.
Work around that by ...

[minux1, 2013-04-22 20:42:14]

*** Submitted as https://code.google.com/p/go/source/detail?r=a907467cea39 ***

misc/cgo/testso: enable test on windows
Depends on CL 8715043 and CL 8676050.
Fixes issue 5273.

R=alex.brainman, r
CC=gobot, golang-dev
https://codereview.appspot.com/8764043