Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(711)

Issue 8702045: Fix config update.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by bac
Modified:
9 years, 7 months ago
Reviewers:
teknico, jeff.pihach, mp+159854
Visibility:
Public.

Description

Fix config update. The call to set_config was not passing the proper parameters resulting in the callback not happening. A test has been added to ensure the two optional parameters are passed properly to ensure this doesn't happen again. https://code.launchpad.net/~bac/juju-gui/update-config/+merge/159854 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix config update. #

Patch Set 3 : Fix config update. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -5 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 2 chunks +2 lines, -1 line 0 comments Download
M app/store/env/go.js View 1 chunk +5 lines, -0 lines 0 comments Download
M app/store/env/python.js View 1 chunk +4 lines, -0 lines 0 comments Download
M app/views/service.js View 1 chunk +1 line, -0 lines 0 comments Download
M lib/views/stylesheet.less View 2 chunks +4 lines, -1 line 0 comments Download
M test/test_env_go.js View 1 chunk +13 lines, -0 lines 0 comments Download
M test/test_env_python.js View 1 chunk +13 lines, -0 lines 0 comments Download
M test/test_service_config_view.js View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5
bac
Please take a look.
9 years, 7 months ago (2013-04-19 16:25:17 UTC) #1
jeff.pihach
LGTM - Thanks for fixing!
9 years, 7 months ago (2013-04-19 16:43:14 UTC) #2
teknico
LGTM too, thanks for the diff Launchpad! :-)
9 years, 7 months ago (2013-04-19 16:45:07 UTC) #3
bac
Please take a look.
9 years, 7 months ago (2013-04-19 17:27:54 UTC) #4
bac
9 years, 7 months ago (2013-04-19 17:44:05 UTC) #5
*** Submitted:

Fix config update.

The call to set_config was not passing the proper parameters resulting in
the callback not happening.  A test has been added to ensure the two
optional parameters are passed properly to ensure this doesn't
happen again.

R=jeff.pihach, teknico
CC=
https://codereview.appspot.com/8702045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b