Issue 8702045: Fix config update.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8702045: Fix config update.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by bac

Modified:
11 years ago

Reviewers:
teknico, jeff.pihach, mp+159854

Visibility:
Public.

Description

Fix config update. The call to set_config was not passing the proper parameters resulting in the callback not happening. A test has been added to ensure the two optional parameters are passed properly to ensure this doesn't happen again. https://code.launchpad.net/~bac/juju-gui/update-config/+merge/159854 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix config update. #

Patch Set 3 : Fix config update. #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -5 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/app.js	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	app/store/env/go.js	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	app/store/env/python.js	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	app/views/service.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/views/stylesheet.less	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	test/test_env_go.js	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	test/test_env_python.js	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	test/test_service_config_view.js	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bac

11 years ago (2013-04-19 17:44:05 UTC) #5

*** Submitted:

Fix config update.

The call to set_config was not passing the proper parameters resulting in
the callback not happening.  A test has been added to ensure the two
optional parameters are passed properly to ensure this doesn't
happen again.

R=jeff.pihach, teknico
CC=
https://codereview.appspot.com/8702045

Expand All Messages | Collapse All Messages