Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(568)

Issue 8661043: environs/cloudinit: fail properly in cloudinit

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by rog
Modified:
8 years, 7 months ago
Reviewers:
mp+158356, dimitern, fwereade
Visibility:
Public.

Description

environs/cloudinit: fail properly in cloudinit If one command fails, we should not carry on and try more. We also cause the executing commands to be printed, so it should be more obvious which command caused the script to fail. https://code.launchpad.net/~rogpeppe/juju-core/281-set-xe/+merge/158356 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/cloudinit: fail properly in cloudinit #

Patch Set 3 : environs/cloudinit: fail properly in cloudinit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M environs/cloudinit/cloudinit.go View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M environs/cloudinit/cloudinit_test.go View 1 2 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5
rog
Please take a look.
8 years, 7 months ago (2013-04-11 13:02:15 UTC) #1
dimitern
LGTM. What do you know - I learn something new about bash all the time ...
8 years, 7 months ago (2013-04-11 13:21:02 UTC) #2
dimitern
LGTM. What do you know - I learn something new about bash all the time ...
8 years, 7 months ago (2013-04-11 13:21:02 UTC) #3
fwereade
as agreed online, we can't have a 40s timeout on the cli if EC2 goes ...
8 years, 7 months ago (2013-04-11 14:07:10 UTC) #4
rog
8 years, 7 months ago (2013-04-15 23:00:46 UTC) #5
*** Submitted:

environs/cloudinit: fail properly in cloudinit

If one command fails, we should not carry on and
try more. We also cause the executing commands to
be printed, so it should be more obvious which command
caused the script to fail.

R=dimitern, fwereade
CC=
https://codereview.appspot.com/8661043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b