environs/cloudinit: fail properly in cloudinit

environs/cloudinit: fail properly in cloudinit

If one command fails, we should not carry on and
try more. We also cause the executing commands to
be printed, so it should be more obvious which command
caused the script to fail.

https://code.launchpad.net/~rogpeppe/juju-core/281-set-xe/+merge/158356

(do not edit description out of merge proposal)

[rog, 2013-04-11 13:02:15]

Please take a look.

[dimitern, 2013-04-11 13:21:02]

LGTM. What do you know - I learn something new about bash all the time :)

[dimitern, 2013-04-11 13:21:02]

LGTM. What do you know - I learn something new about bash all the time :)

[fwereade, 2013-04-11 14:07:10]

as agreed online, we can't have a 40s timeout on the cli if EC2 goes down; if
you're fixing live tests, let the live tests specifically be forgiving of the
errors we think they should be.

The set -ex LGTM, though.

[rog, 2013-04-15 23:00:46]

*** Submitted:

environs/cloudinit: fail properly in cloudinit

If one command fails, we should not carry on and
try more. We also cause the executing commands to
be printed, so it should be more obvious which command
caused the script to fail.

R=dimitern, fwereade
CC=
https://codereview.appspot.com/8661043