Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(897)

Issue 8648043: source mongo from package (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by dfc
Modified:
8 years, 7 months ago
Reviewers:
mp+158265
Visibility:
Public.

Description

source mongo from package This proposal replaces the source of mongo for state servers. Mongo is now installed from a package. The source of this package differs depending on the series of the machine being bootstrapped (which is itself drawn from the tools installed on the machine). For P and Q, the source is a PPA owned by the Juju team. For R and above, mongo is available in the archive. https://code.launchpad.net/~dave-cheney/juju-core/113-juju-bootstrap-raring-cloudinit-III/+merge/158265 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : source mongo from package #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -125 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M environs/cloudinit/cloudinit.go View 4 chunks +12 lines, -8 lines 0 comments Download
M environs/cloudinit/cloudinit_test.go View 1 3 chunks +145 lines, -56 lines 0 comments Download
M environs/ec2/ec2.go View 4 chunks +0 lines, -4 lines 0 comments Download
M environs/mongo.go View 1 chunk +0 lines, -37 lines 0 comments Download
M environs/mongo_test.go View 1 chunk +0 lines, -16 lines 0 comments Download
M environs/openstack/provider.go View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5
dfc
Please take a look.
8 years, 7 months ago (2013-04-11 02:20:17 UTC) #1
rog
LGTM with one trivial https://codereview.appspot.com/8648043/diff/1/environs/cloudinit/cloudinit_test.go File environs/cloudinit/cloudinit_test.go (right): https://codereview.appspot.com/8648043/diff/1/environs/cloudinit/cloudinit_test.go#newcode258 environs/cloudinit/cloudinit_test.go:258: source := struct{ Source, Key ...
8 years, 7 months ago (2013-04-11 06:05:59 UTC) #2
dimitern
LGTM, nice!
8 years, 7 months ago (2013-04-11 07:37:28 UTC) #3
fwereade
LGTM https://codereview.appspot.com/8648043/diff/1/environs/mongo.go File environs/mongo.go (left): https://codereview.appspot.com/8648043/diff/1/environs/mongo.go#oldcode12 environs/mongo.go:12: func MongoURL(env Environ, series, architecture string) string { ...
8 years, 7 months ago (2013-04-11 07:54:03 UTC) #4
dfc
8 years, 7 months ago (2013-04-11 07:57:14 UTC) #5
*** Submitted:

source mongo from package

This proposal replaces the source of mongo for state servers. Mongo is now
installed from a package. The source of this package differs depending on the
series of the machine being bootstrapped (which is itself drawn from the tools
installed on the machine). For P and Q, the source is a PPA owned by the Juju
team. For R and above, mongo is available in the archive.

R=rog, dimitern, fwereade
CC=
https://codereview.appspot.com/8648043

https://codereview.appspot.com/8648043/diff/1/environs/cloudinit/cloudinit_te...
File environs/cloudinit/cloudinit_test.go (right):

https://codereview.appspot.com/8648043/diff/1/environs/cloudinit/cloudinit_te...
environs/cloudinit/cloudinit_test.go:258: source := struct{ Source, Key string
}{
On 2013/04/11 06:05:59, rog wrote:
> honestly, i'd just bite it and define the type outside the function; or just
> pass source and key as args.
> 
> if you do define it as a type, there's no need to export the fields, AFAICS.

Made lower case.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b