source mongo from package

source mongo from package

This proposal replaces the source of mongo for state servers. Mongo is now
installed from a package. The source of this package differs depending on the
series of the machine being bootstrapped (which is itself drawn from the tools
installed on the machine). For P and Q, the source is a PPA owned by the Juju
team. For R and above, mongo is available in the archive.

https://code.launchpad.net/~dave-cheney/juju-core/113-juju-bootstrap-raring-cloudinit-III/+merge/158265

(do not edit description out of merge proposal)

[dfc, 2013-04-11 02:20:17]

Please take a look.

[rog, 2013-04-11 06:05:59]

LGTM with one trivial

https://codereview.appspot.com/8648043/diff/1/environs/cloudinit/cloudinit_te...
File environs/cloudinit/cloudinit_test.go (right):

https://codereview.appspot.com/8648043/diff/1/environs/cloudinit/cloudinit_te...
environs/cloudinit/cloudinit_test.go:258: source := struct{ Source, Key string
}{
honestly, i'd just bite it and define the type outside the function; or just
pass source and key as args.

if you do define it as a type, there's no need to export the fields, AFAICS.

https://codereview.appspot.com/8648043/diff/1/environs/mongo.go
File environs/mongo.go (left):

https://codereview.appspot.com/8648043/diff/1/environs/mongo.go#oldcode12
environs/mongo.go:12: func MongoURL(env Environ, series, architecture string)
string {
yay!

[dimitern, 2013-04-11 07:37:28]

LGTM, nice!

[fwereade, 2013-04-11 07:54:03]

LGTM

https://codereview.appspot.com/8648043/diff/1/environs/mongo.go
File environs/mongo.go (left):

https://codereview.appspot.com/8648043/diff/1/environs/mongo.go#oldcode12
environs/mongo.go:12: func MongoURL(env Environ, series, architecture string)
string {
On 2013/04/11 06:05:59, rog wrote:
> yay!

wooooo!

[dfc, 2013-04-11 07:57:14]

*** Submitted:

source mongo from package

This proposal replaces the source of mongo for state servers. Mongo is now
installed from a package. The source of this package differs depending on the
series of the machine being bootstrapped (which is itself drawn from the tools
installed on the machine). For P and Q, the source is a PPA owned by the Juju
team. For R and above, mongo is available in the archive.

R=rog, dimitern, fwereade
CC=
https://codereview.appspot.com/8648043

https://codereview.appspot.com/8648043/diff/1/environs/cloudinit/cloudinit_te...
File environs/cloudinit/cloudinit_test.go (right):

https://codereview.appspot.com/8648043/diff/1/environs/cloudinit/cloudinit_te...
environs/cloudinit/cloudinit_test.go:258: source := struct{ Source, Key string
}{
On 2013/04/11 06:05:59, rog wrote:
> honestly, i'd just bite it and define the type outside the function; or just
> pass source and key as args.
> 
> if you do define it as a type, there's no need to export the fields, AFAICS.

Made lower case.