code review 85860043: ogle: new arch package for architecture-dependent details

ogle: new arch package for architecture-dependent details
Put the details into a struct for each arch, and have the
server choose the appropriate one.
TODO: For now, the AMD64 architecture is hard-wired.

[r, 2014-04-09 05:14:03]

Hello nigeltao,

I'd like you to review this change to
https://code.google.com/p/ogle

[nigeltao, 2014-04-09 05:23:48]

LGTM.

https://codereview.appspot.com/85860043/diff/1/arch/arch.go
File arch/arch.go (right):

https://codereview.appspot.com/85860043/diff/1/arch/arch.go#newcode16
arch/arch.go:16: // The size of a breakpoint instruction, in bytes.
The comment convention is to start with the name of the thing:

// BreakpointSize is the size of a breakpoint instruction, in bytes.

Similarly below.

https://codereview.appspot.com/85860043/diff/1/arch/arch.go#newcode24
arch/arch.go:24: BreakpointInstr []byte
Would it be more consistent with a breakpoint.origInstr if this was
[MaxBreakpointSize]byte instead of []byte?

https://codereview.appspot.com/85860043/diff/1/arch/arch.go#newcode40
arch/arch.go:40: default:
Slightly shorter is to drop the default and move the panic down one line,
outside the }.

https://codereview.appspot.com/85860043/diff/1/arch/arch.go#newcode41
arch/arch.go:41: panic("no uint size")
s/no/bad/ ?

https://codereview.appspot.com/85860043/diff/1/program/server/server.go
File program/server/server.go (right):

https://codereview.appspot.com/85860043/diff/1/program/server/server.go#newco...
program/server/server.go:265: err := s.ptracePoke(s.proc.Pid, uintptr(pc),
s.arch.BreakpointInstr[:])
Drop the "[:]".

https://codereview.appspot.com/85860043/diff/1/program/server/server.go#newco...
program/server/server.go:275: err := s.ptracePoke(s.proc.Pid, uintptr(pc),
breakpoint.origInstr[:])
breakpoint.origInstr[:s.arch.BreakpointSize]

[r, 2014-04-09 05:33:07]

*** Submitted as https://code.google.com/p/ogle/source/detail?r=82ff9d268a24 ***

ogle: new arch package for architecture-dependent details
Put the details into a struct for each arch, and have the
server choose the appropriate one.
TODO: For now, the AMD64 architecture is hard-wired.

LGTM=nigeltao
R=nigeltao
https://codereview.appspot.com/85860043