Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(104)

Issue 85860043: code review 85860043: ogle: new arch package for architecture-dependent details (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by r
Modified:
7 years, 7 months ago
Reviewers:
nigeltao
CC:
nigeltao
Visibility:
Public.

Description

ogle: new arch package for architecture-dependent details Put the details into a struct for each arch, and have the server choose the appropriate one. TODO: For now, the AMD64 architecture is hard-wired.

Patch Set 1 #

Total comments: 6

Patch Set 2 : diff -r 225be058f807 https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -19 lines) Patch
A arch/arch.go View 1 1 chunk +66 lines, -0 lines 0 comments Download
M program/server/server.go View 1 9 chunks +16 lines, -19 lines 0 comments Download

Messages

Total messages: 3
r
Hello nigeltao, I'd like you to review this change to https://code.google.com/p/ogle
7 years, 7 months ago (2014-04-09 05:14:03 UTC) #1
nigeltao
LGTM. https://codereview.appspot.com/85860043/diff/1/arch/arch.go File arch/arch.go (right): https://codereview.appspot.com/85860043/diff/1/arch/arch.go#newcode16 arch/arch.go:16: // The size of a breakpoint instruction, in ...
7 years, 7 months ago (2014-04-09 05:23:48 UTC) #2
r
7 years, 7 months ago (2014-04-09 05:33:07 UTC) #3
*** Submitted as https://code.google.com/p/ogle/source/detail?r=82ff9d268a24 ***

ogle: new arch package for architecture-dependent details
Put the details into a struct for each arch, and have the
server choose the appropriate one.
TODO: For now, the AMD64 architecture is hard-wired.

LGTM=nigeltao
R=nigeltao
https://codereview.appspot.com/85860043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b